The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Sebastian Siewior <linux-crypto@ml.breakpoint.cc>
To: Adrian Bunk <bunk@kernel.org>
Cc: hskinnemoen@atmel.com, herbert@gondor.apana.org.au,
	davem@davemloft.net, linux-crypto@vger.kernel.org,
	linux-kernel@vger.kernel.org, shannon.nelson@intel.com,
	dan.j.williams@intel.com
Subject: Re: [2.6 patch] add include/asm-avr32/xor.h
Date: Mon, 14 Apr 2008 20:11:40 +0200	[thread overview]
Message-ID: <20080414181140.GA813@Chamillionaire.breakpoint.cc> (raw)
In-Reply-To: <20080414141632.GA6695@cs181133002.pp.htv.fi>

* Adrian Bunk | 2008-04-14 17:16:32 [+0300]:

>This patch fixes the following compile error with CONFIG_MD_RAID456
>on avr32:
>
><--  snip  -->
>
>...
>  CC [M]  crypto/xor.o
>/home/bunk/linux/kernel-2.6/git/linux-2.6/crypto/xor.c:23:21: error: asm/xor.h: No such file or directory
>/home/bunk/linux/kernel-2.6/git/linux-2.6/crypto/xor.c: In function 'calibrate_xor_blocks':
>/home/bunk/linux/kernel-2.6/git/linux-2.6/crypto/xor.c:131: error: 'XOR_TRY_TEMPLATES' undeclared (first use in this function)
>/home/bunk/linux/kernel-2.6/git/linux-2.6/crypto/xor.c:131: error: (Each undeclared identifier is reported only once
>/home/bunk/linux/kernel-2.6/git/linux-2.6/crypto/xor.c:131: error: for each function it appears in.)
>make[2]: *** [crypto/xor.o] Error 1
>
><--  snip  -->
>
>Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
>---
>601f75e99c076c16e2648f4860cac4fc6ce187ea diff --git a/include/asm-avr32/xor.h b/include/asm-avr32/xor.h
>new file mode 100644
>index 0000000..99c87aa
>--- /dev/null
>+++ b/include/asm-avr32/xor.h
>@@ -0,0 +1,6 @@
>+#ifndef _ASM_XOR_H
>+#define _ASM_XOR_H
>+
>+#include <asm-generic/xor.h>
>+
>+#endif

What about providing <linux/xor.h> which includes the right file from
asm/ or asm-generic/ depending on HAVE_.* ?

Sebastian

  reply	other threads:[~2008-04-14 18:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-14 14:16 [2.6 patch] add include/asm-avr32/xor.h Adrian Bunk
2008-04-14 18:11 ` Sebastian Siewior [this message]
2008-04-14 18:15   ` Adrian Bunk
2008-04-14 21:46     ` Sebastian Siewior
2008-04-14 21:50       ` Mike Frysinger
2008-04-14 22:01       ` Adrian Bunk
2008-04-14 22:11         ` Mike Frysinger
2008-04-14 22:27           ` Dan Williams
2008-04-14 22:30             ` Mike Frysinger
2008-04-14 23:45               ` Dan Williams
2008-04-15  0:47                 ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080414181140.GA813@Chamillionaire.breakpoint.cc \
    --to=linux-crypto@ml.breakpoint.cc \
    --cc=bunk@kernel.org \
    --cc=dan.j.williams@intel.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=hskinnemoen@atmel.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shannon.nelson@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox