Re: [PATCH] tty: The big operations rework

[Greg KH <greg@kroah.com>]

On Sun, Apr 13, 2008 at 06:40:11PM +0100, Alan Cox wrote:
> - Operations are now a shared const function block as with most other
> Linux objects
> - Introduce wrappers for some optional functions to get consistent
> behaviour
> - Wrap put_char which used to be patched by the tty layer
> - Document which functions are needed/optional
> - Make put_char report success/fail
> - Cache the driver->ops pointer in the tty as tty->ops
> - Remove various surplus lock calls we no longer need
> - Remove proc_write method as noted by Alexey Dobriyan
> - Introduce some missing sanity checks where certain driver/ldisc
> combinations would oops as they didn't check needed methods were present
> 
> Signed-off-by: Alan Cox <alan@redhat.com>

Very nice, thanks for plugging away on this rework, it's really
appreciated.

If you want, you can add:
	Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
to the patch.

thanks,

greg k-h