* [PATCH] tty: fix routine name in ptmx_open()
@ 2008-04-15 0:55 Hiroshi Shimamoto
2008-04-15 9:58 ` Alan Cox
2008-04-15 22:01 ` Andrew Morton
0 siblings, 2 replies; 3+ messages in thread
From: Hiroshi Shimamoto @ 2008-04-15 0:55 UTC (permalink / raw)
To: linux-kernel
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
At ptmx_open(), the 2nd parameter for check_tty_count() should
be "ptmx_open".
Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
---
drivers/char/tty_io.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/char/tty_io.c b/drivers/char/tty_io.c
index 613ec81..546217d 100644
--- a/drivers/char/tty_io.c
+++ b/drivers/char/tty_io.c
@@ -2774,7 +2774,7 @@ static int ptmx_open(struct inode *inode, struct file *filp)
if (devpts_pty_new(tty->link))
goto out1;
- check_tty_count(tty, "tty_open");
+ check_tty_count(tty, "ptmx_open");
retval = ptm_driver->open(tty, filp);
if (!retval) {
tty_audit_opening();
--
1.5.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] tty: fix routine name in ptmx_open()
2008-04-15 0:55 [PATCH] tty: fix routine name in ptmx_open() Hiroshi Shimamoto
@ 2008-04-15 9:58 ` Alan Cox
2008-04-15 22:01 ` Andrew Morton
1 sibling, 0 replies; 3+ messages in thread
From: Alan Cox @ 2008-04-15 9:58 UTC (permalink / raw)
To: Hiroshi Shimamoto; +Cc: linux-kernel
On Mon, 14 Apr 2008 17:55:49 -0700
Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> wrote:
> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
>
> At ptmx_open(), the 2nd parameter for check_tty_count() should
> be "ptmx_open".
>
> Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Acked-by: Alan Cox <alan@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tty: fix routine name in ptmx_open()
2008-04-15 0:55 [PATCH] tty: fix routine name in ptmx_open() Hiroshi Shimamoto
2008-04-15 9:58 ` Alan Cox
@ 2008-04-15 22:01 ` Andrew Morton
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2008-04-15 22:01 UTC (permalink / raw)
To: Hiroshi Shimamoto; +Cc: linux-kernel, Alan Cox
On Mon, 14 Apr 2008 17:55:49 -0700
Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> wrote:
> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
>
> At ptmx_open(), the 2nd parameter for check_tty_count() should
> be "ptmx_open".
>
> Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
> ---
> drivers/char/tty_io.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/char/tty_io.c b/drivers/char/tty_io.c
> index 613ec81..546217d 100644
> --- a/drivers/char/tty_io.c
> +++ b/drivers/char/tty_io.c
> @@ -2774,7 +2774,7 @@ static int ptmx_open(struct inode *inode, struct file *filp)
> if (devpts_pty_new(tty->link))
> goto out1;
>
> - check_tty_count(tty, "tty_open");
> + check_tty_count(tty, "ptmx_open");
> retval = ptm_driver->open(tty, filp);
> if (!retval) {
> tty_audit_opening();
Of course, using __func__ prevents this sort of bitrot.
Or even #define check_tty_count(tty) __check_tty_count(tty, __func__)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-04-15 22:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-15 0:55 [PATCH] tty: fix routine name in ptmx_open() Hiroshi Shimamoto
2008-04-15 9:58 ` Alan Cox
2008-04-15 22:01 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox