public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vitaliy Gusev <vgusev@openvz.org>
To: David Miller <davem@davemloft.net>
Cc: andi@firstfloor.org, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH][NET] Fix never pruned tcp out-of-order queue
Date: Tue, 15 Apr 2008 12:26:47 +0400	[thread overview]
Message-ID: <200804151226.47729.vgusev@openvz.org> (raw)
In-Reply-To: <20080415.011810.178212948.davem@davemloft.net>

On 15 April 2008 12:18:10 David Miller wrote:
> From: Andi Kleen <andi@firstfloor.org>
> Date: Tue, 15 Apr 2008 10:14:56 +0200
> 
> > The main difference seems to be that
> > sk_rmem_schedule/__sk_mem_schedule is called more often, but it is 
> > unclear how this affects the ooo pruning which only checks
> > the queue length anyways.
> 
> tcp_data_queue() would not do the tcp_prune_ofo_queue() in some
> cases, it's the whole point of the patch.

Yes, if second sk_rmem_schedule() failed then tcp_prune_ofo_queue() is force called
and try sk_rmem_schedule() again.


-- 
Thank,
Vitaliy Gusev

  reply	other threads:[~2008-04-15  8:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-14 17:21 [RFC][PATCH][NET] Fix never pruned tcp out-of-order queue Vitaliy Gusev
2008-04-15  7:34 ` David Miller
2008-04-15  7:59 ` Andi Kleen
2008-04-15  8:01   ` David Miller
2008-04-15  8:14     ` Andi Kleen
2008-04-15  8:18       ` David Miller
2008-04-15  8:26         ` Vitaliy Gusev [this message]
2008-04-15  8:30           ` Andi Kleen
2008-04-15  9:33             ` Vitaliy Gusev
2008-04-15 11:59             ` Alexey Kuznetsov
2008-04-15 13:47               ` Vitaliy Gusev
2008-04-15 13:54               ` Vitaliy Gusev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200804151226.47729.vgusev@openvz.org \
    --to=vgusev@openvz.org \
    --cc=andi@firstfloor.org \
    --cc=davem@davemloft.net \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox