From: Andrew Morton <akpm@linux-foundation.org>
To: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Cc: linux-kernel@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] tty: fix routine name in ptmx_open()
Date: Tue, 15 Apr 2008 15:01:43 -0700 [thread overview]
Message-ID: <20080415150143.e19bb518.akpm@linux-foundation.org> (raw)
In-Reply-To: <4803FD15.6030006@ct.jp.nec.com>
On Mon, 14 Apr 2008 17:55:49 -0700
Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> wrote:
> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
>
> At ptmx_open(), the 2nd parameter for check_tty_count() should
> be "ptmx_open".
>
> Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
> ---
> drivers/char/tty_io.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/char/tty_io.c b/drivers/char/tty_io.c
> index 613ec81..546217d 100644
> --- a/drivers/char/tty_io.c
> +++ b/drivers/char/tty_io.c
> @@ -2774,7 +2774,7 @@ static int ptmx_open(struct inode *inode, struct file *filp)
> if (devpts_pty_new(tty->link))
> goto out1;
>
> - check_tty_count(tty, "tty_open");
> + check_tty_count(tty, "ptmx_open");
> retval = ptm_driver->open(tty, filp);
> if (!retval) {
> tty_audit_opening();
Of course, using __func__ prevents this sort of bitrot.
Or even #define check_tty_count(tty) __check_tty_count(tty, __func__)
prev parent reply other threads:[~2008-04-15 22:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-15 0:55 [PATCH] tty: fix routine name in ptmx_open() Hiroshi Shimamoto
2008-04-15 9:58 ` Alan Cox
2008-04-15 22:01 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080415150143.e19bb518.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=h-shimamoto@ct.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox