Re: [PATCH] Replace completions with semaphores

[Matthew Wilcox <matthew@wil.cx>]

On Tue, Apr 15, 2008 at 10:26:21AM -0700, Linus Torvalds wrote:
> MUCH more trivial than this complex series.
> 
> (You may think that the "Replace completions with semaphores" patch is not 
> very complicated, but it *is* - it depends very intimately on the big 
> patch-series that basically turns semaphores into what completions are 
> now!)

complex?  big?  The big bits are dealing with renaming asm/semaphore.h to
linux/semaphore.h, and I've dropped those out now.  There's a couple of
up-front patches which add inclusions of asm/semaphore.h to files which
were missing it.  Then I add the new semaphore implementation, delete
the old ones, and add the down_timeout() and down_killable() functions.

> In other words, what makes me not like this is hat we first turn 
> semaphores into the generic code (which is largely what completions were: 
> just a special case of the generic semaphores!) and then turns completions 
> into these things. That just doesn't make any sense to me!

Blame me for not realising that completions were semaphores under a
different name.

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."