From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753685AbYDORlg (ORCPT ); Tue, 15 Apr 2008 13:41:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751210AbYDORl1 (ORCPT ); Tue, 15 Apr 2008 13:41:27 -0400 Received: from palinux.external.hp.com ([192.25.206.14]:51555 "EHLO mail.parisc-linux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750853AbYDORl0 (ORCPT ); Tue, 15 Apr 2008 13:41:26 -0400 Date: Tue, 15 Apr 2008 11:41:09 -0600 From: Matthew Wilcox To: Linus Torvalds Cc: Andi Kleen , Peter Zijlstra , Bart Van Assche , Roland Dreier , Ingo Molnar , Ingo Oeser , Daniel Walker , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Replace completions with semaphores Message-ID: <20080415174109.GD9191@parisc-linux.org> References: <4803AD91.5020001@firstfloor.org> <1208242017.7053.4.camel@lappy> <1208249088.7124.7.camel@twins> <4804D779.6070907@firstfloor.org> <4804E29F.9060703@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 15, 2008 at 10:26:21AM -0700, Linus Torvalds wrote: > MUCH more trivial than this complex series. > > (You may think that the "Replace completions with semaphores" patch is not > very complicated, but it *is* - it depends very intimately on the big > patch-series that basically turns semaphores into what completions are > now!) complex? big? The big bits are dealing with renaming asm/semaphore.h to linux/semaphore.h, and I've dropped those out now. There's a couple of up-front patches which add inclusions of asm/semaphore.h to files which were missing it. Then I add the new semaphore implementation, delete the old ones, and add the down_timeout() and down_killable() functions. > In other words, what makes me not like this is hat we first turn > semaphores into the generic code (which is largely what completions were: > just a special case of the generic semaphores!) and then turns completions > into these things. That just doesn't make any sense to me! Blame me for not realising that completions were semaphores under a different name. -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."