From: Greg KH <gregkh@suse.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Pierre Ossman <drzeus-list@drzeus.cx>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: pci: add to global list before sysfs?
Date: Tue, 15 Apr 2008 12:13:33 -0700 [thread overview]
Message-ID: <20080415191333.GA28671@suse.de> (raw)
In-Reply-To: <1208122538.6958.57.camel@pasglop>
On Mon, Apr 14, 2008 at 07:35:38AM +1000, Benjamin Herrenschmidt wrote:
>
> On Fri, 2008-04-04 at 14:01 -0700, Greg KH wrote:
> > As I mention above, the "global list" is now gone, so it's going to be
> > a
> > bit harder to do this. We now only keep one list of all PCI devices,
> > and that is with the driver core mechanisms as the duplicate list was
> > just sitting there doing nothing for the past 4 years.
> >
> > So is the problem that your driver need to bind to multiple pci
> > devices
> > at the same time in order to work properly?
> >
> > Or is this just really broken hardware?
>
> Haven't had a chance to look at your changes yet, but I have memories of
> being pretty happy with having that 2 step mechanism in PCI where the
> driver core would only see the devices after fixup.
No, that is left alone, I just dropped the duplicate device list that
was linked within the PCI devices themselves. The only user of it was
the "reorder the PCI devices" code for some Dell machines, and that was
just doing it to be safe (it was also reordering the driver core list of
PCI devices, which is what really mattered.)
So everything should still be fine.
thanks,
greg k-h
next prev parent reply other threads:[~2008-04-15 19:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-04 17:13 pci: add to global list before sysfs? Pierre Ossman
2008-04-04 21:01 ` Greg KH
2008-04-05 9:57 ` Pierre Ossman
2008-04-05 15:53 ` Greg KH
2008-04-05 16:55 ` Pierre Ossman
2008-04-05 17:12 ` Greg KH
2008-04-05 18:27 ` Pierre Ossman
2008-04-08 3:41 ` Greg KH
2008-04-13 12:33 ` Pierre Ossman
2008-04-13 17:51 ` Greg KH
2008-04-13 21:37 ` Benjamin Herrenschmidt
2008-04-14 8:35 ` Pierre Ossman
2008-04-14 8:57 ` Benjamin Herrenschmidt
2008-04-14 8:58 ` Benjamin Herrenschmidt
2008-04-14 10:58 ` Pierre Ossman
2008-04-13 21:35 ` Benjamin Herrenschmidt
2008-04-15 19:13 ` Greg KH [this message]
2008-04-15 21:53 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080415191333.GA28671@suse.de \
--to=gregkh@suse.de \
--cc=benh@kernel.crashing.org \
--cc=drzeus-list@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox