From: tsbogend@alpha.franken.de (Thomas Bogendoerfer)
To: Roel Kluin <12o3l@tiscali.nl>
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/6 v2] MIPS: ip27-timer: unsigned irq to evaluate allocate_irqno()
Date: Thu, 17 Apr 2008 00:27:56 +0200 [thread overview]
Message-ID: <20080416222755.GA18832@alpha.franken.de> (raw)
In-Reply-To: <480616C6.3080203@tiscali.nl>
On Wed, Apr 16, 2008 at 05:09:58PM +0200, Roel Kluin wrote:
> Thomas Bogendoerfer wrote:
> > On Wed, Apr 16, 2008 at 03:43:56AM +0200, Roel Kluin wrote:
> >> irq is unsigned, cast to signed to evaluate the allocate_irqno() return value,
>
> >> + if ((int) irq < 0)
> >
> > Why don't you just make irq and rt_timer_irq an int ?
>
> Ok, thanks, It should be right, but I cannot test this (no hardware).
I've tested it on real hardware.
Acked-By: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessary a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2008-04-16 22:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-16 1:43 [PATCH 2/6] MIPS: ip27-timer: fix unsigned irq < 0 Roel Kluin
2008-04-16 9:15 ` Thomas Bogendoerfer
2008-04-16 15:09 ` [PATCH 2/6 v2] MIPS: ip27-timer: unsigned irq to evaluate allocate_irqno() Roel Kluin
2008-04-16 22:27 ` Thomas Bogendoerfer [this message]
2008-04-17 10:59 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080416222755.GA18832@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=12o3l@tiscali.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox