From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756574AbYDRIjX (ORCPT ); Fri, 18 Apr 2008 04:39:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753103AbYDRIjM (ORCPT ); Fri, 18 Apr 2008 04:39:12 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:45559 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752771AbYDRIjK (ORCPT ); Fri, 18 Apr 2008 04:39:10 -0400 Date: Fri, 18 Apr 2008 01:38:57 -0700 From: Andrew Morton To: benh@kernel.crashing.org Cc: Paul Mackerras , linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org, Linux-Arch Subject: Re: [PATCH 3/3] Use __weak macro for smp_setup_processor_id Message-Id: <20080418013857.92824cfb.akpm@linux-foundation.org> In-Reply-To: <1208506747.6958.402.camel@pasglop> References: <20080418065728.31AF4DE255@ozlabs.org> <20080418000717.5a9c9758.akpm@linux-foundation.org> <1208506747.6958.402.camel@pasglop> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 18 Apr 2008 18:19:07 +1000 Benjamin Herrenschmidt wrote: > > On Fri, 2008-04-18 at 00:07 -0700, Andrew Morton wrote: > > On Fri, 18 Apr 2008 16:56:18 +1000 Benjamin Herrenschmidt wrote: > > > > > Use the __weak macro instead of the longer __attribute__ ((weak)) form > > > > > > Signed-off-by: Benjamin Herrenschmidt > > > -- > > > > > > init/main.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > --- linux-work.orig/init/main.c 2008-04-18 16:44:32.000000000 +1000 > > > +++ linux-work/init/main.c 2008-04-18 16:44:37.000000000 +1000 > > > @@ -500,7 +500,7 @@ static void __init boot_cpu_init(void) > > > cpu_set(cpu, cpu_possible_map); > > > } > > > > > > -void __init __attribute__((weak)) smp_setup_processor_id(void) > > > +void __init __weak smp_setup_processor_id(void) > > > { > > > } > > > > ack on all three. Please fold #3 into #1 and add both to git-powerpc. > > Damn ! I took 5mn to actually split it out in order to not do two > different things in one patch :-) ah, I misread it. I thought this was changing the __attribute__((weak)) which patch #1 added. But it's changing a different one. I though that was odd. > Will do. whatever ;)