public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Michael Karcher <kernel@mkarcher.dialup.fu-berlin.de>
Cc: smurf@smurf.noris.de, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb-serial: option: Don't match Huawei driver CD images
Date: Thu, 17 Apr 2008 20:24:05 -0700	[thread overview]
Message-ID: <20080418032405.GB8754@kroah.com> (raw)
In-Reply-To: <1208472569.14194.5.camel@hermes2.karcher.local>

On Fri, Apr 18, 2008 at 12:49:29AM +0200, Michael Karcher wrote:
> From: Michael Karcher <kernel@mkarcher.dialup.fu-berlin.de>
> 
> Add the interface info matching to all Huawei cards, as they all also
> contain a Mass Storage Device interface (usually containing Windows
> drivers) which should not get bound by this driver.
> 
> See also drivers/usb/storage/unusual_devs.h
> 
> Signed-off-by: Michael Karcher <kernel@mkarcher.dialup.fu-berlin.de>
> 
> ---
> 
> Formatting as one-liners is done like in HUAWEI_PRODUCT_E220 entries
> that were already present. This breaks the 80 chars/line recommendation,
> feel free to reformat (or tell me to submit a reformatted patch).
> 
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c

What is this patch against?  We have a change that went into 2.6.25
after 2.6.25-rc9 that should make this patch not be needed.

Can you try that release and verify this?

thanks,

greg k-h

  reply	other threads:[~2008-04-18  3:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-17 22:49 [PATCH] usb-serial: option: Don't match Huawei driver CD images Michael Karcher
2008-04-18  3:24 ` Greg KH [this message]
2008-04-18  6:01   ` Michael Karcher
2008-04-18  6:30     ` Michael Karcher
2008-05-28 17:17       ` Greg KH
2008-05-28 21:58         ` Michael Karcher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080418032405.GB8754@kroah.com \
    --to=greg@kroah.com \
    --cc=kernel@mkarcher.dialup.fu-berlin.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=smurf@smurf.noris.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox