From: Andrew Morton <akpm@linux-foundation.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Pekka Paalanen <pq@iki.fi>,
Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Soeren Sandmann Pedersen <sandmann@redhat.com>,
Steven Rostedt <srostedt@redhat.com>
Subject: Re: [PATCH sched-devel] ftrace: trace_entries to change trace buffer size
Date: Fri, 18 Apr 2008 12:14:31 -0700 [thread overview]
Message-ID: <20080418121431.7f1c05f1.akpm@linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0804180822510.5642@gandalf.stny.rr.com>
On Fri, 18 Apr 2008 08:48:09 -0400 (EDT) Steven Rostedt <rostedt@goodmis.org> wrote:
> > > + data->lock = (raw_spinlock_t)__RAW_SPIN_LOCK_UNLOCKED;
> > > + max_tr.data[i]->lock = (raw_spinlock_t)__RAW_SPIN_LOCK_UNLOCKED;
> >
> > eww. This *really* needs explanatory comments.
> >
>
> Actually, that's just a way of doing spin_lock_init for raw spin locks. I
> didn't see any other way.
Maybe we need raw_spin_lock_init(). And DEFINE_RAW_SPINLOCK()?
Although it isn't a great idea to be encouraging the use of raw
spinlocks.
next prev parent reply other threads:[~2008-04-18 19:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080411163923.439680284@goodmis.org>
[not found] ` <20080411164037.219665668@goodmis.org>
[not found] ` <20080411214328.25c06a5d@daedalus.pq.iki.fi>
[not found] ` <Pine.LNX.4.58.0804112021200.4500@gandalf.stny.rr.com>
[not found] ` <20080413145604.3fb396a2@daedalus.pq.iki.fi>
[not found] ` <20080414095645.GC3761@elte.hu>
[not found] ` <20080414211433.3bfa5649@daedalus.pq.iki.fi>
2008-04-15 1:41 ` [PATCH sched-devel] ftrace: trace_entries to change trace buffer size Steven Rostedt
2008-04-18 10:23 ` Andrew Morton
2008-04-18 12:48 ` Steven Rostedt
2008-04-18 19:14 ` Andrew Morton [this message]
2008-04-18 19:25 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080418121431.7f1c05f1.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=pq@iki.fi \
--cc=rostedt@goodmis.org \
--cc=sandmann@redhat.com \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox