From: Andrew Morton <akpm@linux-foundation.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, rostedt@goodmis.org,
peterz@infradead.org, sandmann@redhat.com, pq@iki.fi,
srostedt@redhat.com
Subject: Re: [PATCH 1/5] ftrace: simple clean ups
Date: Fri, 18 Apr 2008 13:15:35 -0700 [thread overview]
Message-ID: <20080418131535.dbcd315d.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080418200849.968033091@goodmis.org>
On Fri, 18 Apr 2008 16:05:39 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> - r = snprintf(buf, 64, "%ld\n",
> + r = snprintf(buf, sizeof(buf), "%ld\n",
If you use scnprintf here
> *ptr == (unsigned long)-1 ? -1 : nsecs_to_usecs(*ptr));
> - if (r > 64)
> - r = 64;
> + if (r > sizeof(buf))
> + r = sizeof(buf);
This becomes a cant-happen (I think).
next prev parent reply other threads:[~2008-04-18 20:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-18 20:05 [PATCH 0/5] ftrace update patches Steven Rostedt
2008-04-18 20:05 ` [PATCH 1/5] ftrace: simple clean ups Steven Rostedt
2008-04-18 20:15 ` Andrew Morton [this message]
2008-04-19 3:09 ` Steven Rostedt
2008-04-19 3:11 ` [PATCH 1/5 -v2] " Steven Rostedt
2008-04-18 20:05 ` [PATCH 2/5] ftrace: replace simple_strtoul with strict_strtoul Steven Rostedt
2008-04-18 20:05 ` [PATCH 3/5] ftrace: modulize the number of CPU buffers Steven Rostedt
2008-04-18 20:05 ` [PATCH 4/5] ftrace: limit trace entries Steven Rostedt
2008-04-18 20:19 ` Andrew Morton
2008-04-19 3:12 ` Steven Rostedt
2008-04-19 3:32 ` Andrew Morton
2008-04-19 3:17 ` [PATCH 4/5 -v2] " Steven Rostedt
2008-04-19 6:10 ` [PATCH 4/5] " Ingo Molnar
2008-04-18 20:05 ` [PATCH 5/5] ftrace: comment code Steven Rostedt
2008-04-19 6:11 ` [PATCH 0/5] ftrace update patches Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080418131535.dbcd315d.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=pq@iki.fi \
--cc=rostedt@goodmis.org \
--cc=sandmann@redhat.com \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox