From: Andrew Morton <akpm@linux-foundation.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Introduce down_killable()
Date: Fri, 18 Apr 2008 15:34:55 -0700 [thread overview]
Message-ID: <20080418153455.4d0bee30.akpm@linux-foundation.org> (raw)
In-Reply-To: <200804181705.m3IH56W4007130@hera.kernel.org>
On Fri, 18 Apr 2008 17:05:06 GMT
Linux Kernel Mailing List <linux-kernel@vger.kernel.org> wrote:
> --- a/kernel/semaphore.c
> +++ b/kernel/semaphore.c
> @@ -34,6 +34,7 @@
>
> static noinline void __down(struct semaphore *sem);
> static noinline int __down_interruptible(struct semaphore *sem);
> +static noinline int __down_killable(struct semaphore *sem);
> static noinline void __up(struct semaphore *sem);
What is the reason for all the noinlines in this file?
Something to do with getting proper wchan output? I guess it doesn't hurt
from a documentation POV, but did you find that it was actually necessary?
IOW: is gcc now capable of secretly inlining functions which are defined
further ahead in the compilation unit?
(did you actually "test" the wchan stuff, btw?)
next parent reply other threads:[~2008-04-18 22:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200804181705.m3IH56W4007130@hera.kernel.org>
2008-04-18 22:34 ` Andrew Morton [this message]
2008-04-18 22:55 ` Introduce down_killable() Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080418153455.4d0bee30.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox