From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755926AbYDRXct (ORCPT ); Fri, 18 Apr 2008 19:32:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752122AbYDRXcm (ORCPT ); Fri, 18 Apr 2008 19:32:42 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:34814 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751319AbYDRXcl (ORCPT ); Fri, 18 Apr 2008 19:32:41 -0400 Date: Fri, 18 Apr 2008 16:32:26 -0700 From: Andrew Morton To: "Yinghai Lu" Cc: yhlu.kernel.send@gmail.com, mingo@elte.hu, linux-kernel@vger.kernel.org Subject: Re: x86: memtest bootparam Message-Id: <20080418163226.1d8f2a62.akpm@linux-foundation.org> In-Reply-To: <86802c440804181507t4baf6c4dl1a68f89d3d7ce47c@mail.gmail.com> References: <200804181717.m3IHHicT031344@hera.kernel.org> <20080418145202.c96460a2.akpm@linux-foundation.org> <86802c440804181507t4baf6c4dl1a68f89d3d7ce47c@mail.gmail.com> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 18 Apr 2008 15:07:46 -0700 "Yinghai Lu" wrote: > On Fri, Apr 18, 2008 at 2:52 PM, Andrew Morton > wrote: > > On Fri, 18 Apr 2008 17:17:44 GMT > > Linux Kernel Mailing List wrote: > > > > > Gitweb: http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=c64df70793a9c344874eb4af19f85e0662d2d3ee > > > Commit: c64df70793a9c344874eb4af19f85e0662d2d3ee > > > Parent: 9b967106da0357ef8b08847dce35584a04134f20 > > > Author: Yinghai Lu > > > AuthorDate: Fri Mar 21 18:56:19 2008 -0700 > > > Committer: Ingo Molnar > > > CommitDate: Thu Apr 17 17:41:21 2008 +0200 > > > > > > x86: memtest bootparam > > > > > > ... > > > > > > > > > + memtest= [KNL,X86_64] Enable memtest > > > + Format: > > > + range: 0,4 : pattern number > > > + default : 0 > > > > OK. Did the new memtest feature get documented anywhere, btw? I'm only > > vaguely aware of its existence. > > need one text file in Documentation ? Well if there was a single CONFIG_MEMTEST then it would probably be sufficent to document it all within the Kconfig help for that option. But there isn't a CONFIG_MEMTEST. It appears that the presence or absence of the memtest feature is controlled by CONFIG_MEMTEST_BOOTPARAM which makes no sense at all! > > These seem pointless. Why not just unconditionally implement memtest=? > > All the code for that should be __init anyway so we're hardly saving > > anything here. > > also > for big box, like 64g above, that will take a while. So... such users shouldn't add the memtest= boot parameter? I'd suggest the following: - Add a CONFIG_MEMTEST. No other config variable needed. - Put all the memtest code inside #ifdef CONFIG_MEMTEST. - As part of that memtest code, implement the memtest= boot option - Make the memtest feature default to "off" if memtest= was not provided. That's all very simple and conventional?