From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: kgdb build fix
Date: Fri, 18 Apr 2008 21:51:04 +0400 [thread overview]
Message-ID: <20080418175104.GD7674@cvg> (raw)
In-Reply-To: <1208537678.17196.40.camel@brick>
[Harvey Harrison - Fri, Apr 18, 2008 at 09:54:38AM -0700]
| TF_MASK is no longer defined, use X86_EFLAGS_TF.
|
| Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
| ---
| In current -linus tree.
|
| arch/x86/kernel/kgdb.c | 4 ++--
| 1 files changed, 2 insertions(+), 2 deletions(-)
|
| diff --git a/arch/x86/kernel/kgdb.c b/arch/x86/kernel/kgdb.c
| index 8c7e555..24362ec 100644
| --- a/arch/x86/kernel/kgdb.c
| +++ b/arch/x86/kernel/kgdb.c
| @@ -375,12 +375,12 @@ int kgdb_arch_handle_exception(int e_vector, int signo, int err_code,
| newPC = linux_regs->ip;
|
| /* clear the trace bit */
| - linux_regs->flags &= ~TF_MASK;
| + linux_regs->flags &= ~X86_EFLAGS_TF;
| atomic_set(&kgdb_cpu_doing_single_step, -1);
|
| /* set the trace bit if we're stepping */
| if (remcomInBuffer[0] == 's') {
| - linux_regs->flags |= TF_MASK;
| + linux_regs->flags |= X86_EFLAGS_TF;
| kgdb_single_step = 1;
| if (kgdb_contthread) {
| atomic_set(&kgdb_cpu_doing_single_step,
| --
| 1.5.5.144.g3e42
|
It seems to be my fault, thanks a lot Harvey!
- Cyrill -
next prev parent reply other threads:[~2008-04-18 17:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-18 16:54 [PATCH] x86: kgdb build fix Harvey Harrison
2008-04-18 17:51 ` Cyrill Gorcunov [this message]
2008-04-18 17:57 ` Cyrill Gorcunov
2008-04-18 21:33 ` Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2008-04-19 8:19 [patch] x86: KGDB " Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080418175104.GD7674@cvg \
--to=gorcunov@gmail.com \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox