From: Andrew Morton <akpm@linux-foundation.org>
To: Mike Travis <travis@sgi.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: x86: clean up non-smp usage of cpu maps
Date: Fri, 18 Apr 2008 20:04:14 -0700 [thread overview]
Message-ID: <20080418200414.16dbe916.akpm@linux-foundation.org> (raw)
In-Reply-To: <4809573E.4010406@sgi.com>
On Fri, 18 Apr 2008 19:21:50 -0700 Mike Travis <travis@sgi.com> wrote:
> Andrew Morton wrote:
> > On Fri, 18 Apr 2008 17:36:55 GMT Linux Kernel Mailing List <linux-kernel@vger.kernel.org> wrote:
> >
> >> x86: clean up non-smp usage of cpu maps
> >>
> >> Cleanup references to the early cpu maps for the non-SMP configuration
> >> and remove some functions called for SMP configurations only.
> >>
> >> ...
> >>
> >> index 1179aa0..dc79409 100644
> >> --- a/arch/x86/kernel/setup.c
> >> +++ b/arch/x86/kernel/setup.c
> >> @@ -10,7 +10,7 @@
> >> #include <asm/setup.h>
> >> #include <asm/topology.h>
> >>
> >> -#ifdef CONFIG_HAVE_SETUP_PER_CPU_AREA
> >> +#if defined(CONFIG_HAVE_SETUP_PER_CPU_AREA) && defined(CONFIG_SMP)
> >
> > This implies that we can have
> >
> > CONFIG_HAVE_SETUP_PER_CPU_AREA && !CONFIG_SMP
> >
> > which a) appears to be true and b) seems rather dumb?
>
> Yeah, I kind of picked that up in a code merge and didn't really look at it
> too closely. I should have checked the Kconfig file to make sure that it
> couldn't inadvertently get set if SMP is not set.
config HAVE_SETUP_PER_CPU_AREA
def_bool X86_64 || (X86_SMP && !X86_VOYAGER)
it _can_ get set at present on x86_64, which I assume is incorrect.
prev parent reply other threads:[~2008-04-19 3:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200804181736.m3IHatLo009568@hera.kernel.org>
2008-04-19 1:49 ` x86: clean up non-smp usage of cpu maps Andrew Morton
2008-04-19 2:21 ` Mike Travis
2008-04-19 3:04 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080418200414.16dbe916.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox