From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758288AbYDSQVu (ORCPT ); Sat, 19 Apr 2008 12:21:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753547AbYDSQVn (ORCPT ); Sat, 19 Apr 2008 12:21:43 -0400 Received: from mx1.redhat.com ([66.187.233.31]:33577 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751096AbYDSQVn (ORCPT ); Sat, 19 Apr 2008 12:21:43 -0400 Date: Sat, 19 Apr 2008 12:16:34 -0400 From: Alan Cox To: Jeff Garzik Cc: alan@redhat.com, R.E.Wolff@BitWizard.nl, Andrew Morton , LKML Subject: Re: [PATCH 05/15] drivers/char: minor irq handler cleanups Message-ID: <20080419161634.GA16424@devserv.devel.redhat.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a Lloegr o'r rhif cofrestru 3798903 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 18, 2008 at 07:22:51PM -0400, Jeff Garzik wrote: > +++ b/drivers/char/cyclades.c > if (unlikely(!ISZLOADED(*cinfo))) { > #ifdef CY_DEBUG_INTERRUPTS > - printk(KERN_DEBUG "cyz_interrupt: board not yet loaded " > - "(IRQ%d).\n", irq); > + printk(KERN_DEBUG "cyz_interrupt: board not yet loaded\n"); If you are debugging IRQ funnies you really really want to know which IRQ or which port. Ack the rest on the base the __foo_interrupt uglies will go away with the final change over. A follow up patch to tweak cyclades would be useful and also to know from Andrew if these are going in so they don't clash with the coding style cleanups also queued.