* [2.6 patch] sparc: export kmap_atomic_to_page
@ 2008-04-14 14:19 Adrian Bunk
2008-04-15 7:39 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2008-04-14 14:19 UTC (permalink / raw)
To: Mark Salyzyn, James Bottomley, wli; +Cc: sparclinux, linux-scsi, linux-kernel
This patch fixes the following build error exposed by commit
3a0086a80ab7c2f1adb0e9b2a6fc82632979cec5:
<-- snip -->
MODPOST 1741 modules
ERROR: "kmap_atomic_to_page" [drivers/scsi/aacraid/aacraid.ko] undefined!
...
make[2]: *** [__modpost] Error 1
<-- snip -->
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
arch/sparc/mm/highmem.c | 2 ++
1 file changed, 2 insertions(+)
e0d104bd0a5560ef4c836af8eb1ddd70dfb01db5 diff --git a/arch/sparc/mm/highmem.c b/arch/sparc/mm/highmem.c
index 01fc6c2..145ac7f 100644
--- a/arch/sparc/mm/highmem.c
+++ b/arch/sparc/mm/highmem.c
@@ -24,6 +24,7 @@
*/
#include <linux/mm.h>
#include <linux/highmem.h>
+#include <linux/module.h>
#include <asm/pgalloc.h>
#include <asm/cacheflush.h>
#include <asm/tlbflush.h>
@@ -116,3 +117,4 @@ struct page *kmap_atomic_to_page(void *ptr)
pte = kmap_pte - (idx - FIX_KMAP_BEGIN);
return pte_page(*pte);
}
+EXPORT_SYMBOL_GPL(kmap_atomic_to_page);
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [2.6 patch] sparc: export kmap_atomic_to_page
2008-04-14 14:19 [2.6 patch] sparc: export kmap_atomic_to_page Adrian Bunk
@ 2008-04-15 7:39 ` David Miller
2008-04-20 20:14 ` Adrian Bunk
0 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2008-04-15 7:39 UTC (permalink / raw)
To: bunk; +Cc: aacraid, James.Bottomley, wli, sparclinux, linux-scsi,
linux-kernel
From: Adrian Bunk <bunk@kernel.org>
Date: Mon, 14 Apr 2008 17:19:56 +0300
> This patch fixes the following build error exposed by commit
> 3a0086a80ab7c2f1adb0e9b2a6fc82632979cec5:
Please provide the commit header text as well as the ID when referring
to commits, because when backported to stable trees the ID might
be different.
I've fixed this up for you.
> <-- snip -->
>
> MODPOST 1741 modules
> ERROR: "kmap_atomic_to_page" [drivers/scsi/aacraid/aacraid.ko] undefined!
> ...
> make[2]: *** [__modpost] Error 1
>
> <-- snip -->
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
Applied, thanks Adrian.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [2.6 patch] sparc: export kmap_atomic_to_page
2008-04-15 7:39 ` David Miller
@ 2008-04-20 20:14 ` Adrian Bunk
2008-04-20 20:28 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2008-04-20 20:14 UTC (permalink / raw)
To: David Miller
Cc: aacraid, James.Bottomley, wli, sparclinux, linux-scsi,
linux-kernel
On Tue, Apr 15, 2008 at 12:39:10AM -0700, David Miller wrote:
> From: Adrian Bunk <bunk@kernel.org>
>...
> > <-- snip -->
> >
> > MODPOST 1741 modules
> > ERROR: "kmap_atomic_to_page" [drivers/scsi/aacraid/aacraid.ko] undefined!
> > ...
> > make[2]: *** [__modpost] Error 1
> >
> > <-- snip -->
> >
> > Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> Applied, thanks Adrian.
Please drop - aacraid no longer uses it in 2.6.26.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [2.6 patch] sparc: export kmap_atomic_to_page
2008-04-20 20:14 ` Adrian Bunk
@ 2008-04-20 20:28 ` David Miller
2008-04-20 23:40 ` Matthew Wilcox
0 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2008-04-20 20:28 UTC (permalink / raw)
To: bunk; +Cc: aacraid, James.Bottomley, wli, sparclinux, linux-scsi,
linux-kernel
From: Adrian Bunk <bunk@kernel.org>
Date: Sun, 20 Apr 2008 23:14:43 +0300
> On Tue, Apr 15, 2008 at 12:39:10AM -0700, David Miller wrote:
> > From: Adrian Bunk <bunk@kernel.org>
> >...
> > > <-- snip -->
> > >
> > > MODPOST 1741 modules
> > > ERROR: "kmap_atomic_to_page" [drivers/scsi/aacraid/aacraid.ko] undefined!
> > > ...
> > > make[2]: *** [__modpost] Error 1
> > >
> > > <-- snip -->
> > >
> > > Signed-off-by: Adrian Bunk <bunk@kernel.org>
> >
> > Applied, thanks Adrian.
>
> Please drop - aacraid no longer uses it in 2.6.26.
Ok, will do.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [2.6 patch] sparc: export kmap_atomic_to_page
2008-04-20 20:28 ` David Miller
@ 2008-04-20 23:40 ` Matthew Wilcox
2008-04-20 23:55 ` Adrian Bunk
0 siblings, 1 reply; 6+ messages in thread
From: Matthew Wilcox @ 2008-04-20 23:40 UTC (permalink / raw)
To: David Miller
Cc: bunk, aacraid, James.Bottomley, wli, sparclinux, linux-scsi,
linux-kernel
On Sun, Apr 20, 2008 at 01:28:29PM -0700, David Miller wrote:
> From: Adrian Bunk <bunk@kernel.org>
> Date: Sun, 20 Apr 2008 23:14:43 +0300
>
> > On Tue, Apr 15, 2008 at 12:39:10AM -0700, David Miller wrote:
> > > From: Adrian Bunk <bunk@kernel.org>
> > >...
> > > > <-- snip -->
> > > >
> > > > MODPOST 1741 modules
> > > > ERROR: "kmap_atomic_to_page" [drivers/scsi/aacraid/aacraid.ko] undefined!
> > > > ...
> > > > make[2]: *** [__modpost] Error 1
> > > >
> > > > <-- snip -->
> > > >
> > > > Signed-off-by: Adrian Bunk <bunk@kernel.org>
> > >
> > > Applied, thanks Adrian.
> >
> > Please drop - aacraid no longer uses it in 2.6.26.
>
> Ok, will do.
Looks like the only remaining user is in mm/shmem.c. I guess it can be
unexported now?
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [2.6 patch] sparc: export kmap_atomic_to_page
2008-04-20 23:40 ` Matthew Wilcox
@ 2008-04-20 23:55 ` Adrian Bunk
0 siblings, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2008-04-20 23:55 UTC (permalink / raw)
To: Matthew Wilcox
Cc: David Miller, aacraid, James.Bottomley, wli, sparclinux,
linux-scsi, linux-kernel
On Sun, Apr 20, 2008 at 05:40:11PM -0600, Matthew Wilcox wrote:
> On Sun, Apr 20, 2008 at 01:28:29PM -0700, David Miller wrote:
> > From: Adrian Bunk <bunk@kernel.org>
> > Date: Sun, 20 Apr 2008 23:14:43 +0300
> >
> > > On Tue, Apr 15, 2008 at 12:39:10AM -0700, David Miller wrote:
> > > > From: Adrian Bunk <bunk@kernel.org>
> > > >...
> > > > > <-- snip -->
> > > > >
> > > > > MODPOST 1741 modules
> > > > > ERROR: "kmap_atomic_to_page" [drivers/scsi/aacraid/aacraid.ko] undefined!
> > > > > ...
> > > > > make[2]: *** [__modpost] Error 1
> > > > >
> > > > > <-- snip -->
> > > > >
> > > > > Signed-off-by: Adrian Bunk <bunk@kernel.org>
> > > >
> > > > Applied, thanks Adrian.
> > >
> > > Please drop - aacraid no longer uses it in 2.6.26.
> >
> > Ok, will do.
>
> Looks like the only remaining user is in mm/shmem.c. I guess it can be
> unexported now?
I'm already doing this (but the test compiles are still running).
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-04-20 23:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-14 14:19 [2.6 patch] sparc: export kmap_atomic_to_page Adrian Bunk
2008-04-15 7:39 ` David Miller
2008-04-20 20:14 ` Adrian Bunk
2008-04-20 20:28 ` David Miller
2008-04-20 23:40 ` Matthew Wilcox
2008-04-20 23:55 ` Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox