From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Jeff Garzik <jeff@garzik.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel@wantstofly.org, linux-arm-kernel@lists.arm.linux.org.uk,
galak@kernel.crashing.org, David Miller <davem@davemloft.net>,
kkeil@suse.de, isdn4linux@listserv.isdn4linux.de,
cooloney@kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [git patches] minor irq handler cleanups
Date: Mon, 21 Apr 2008 08:42:41 +0100 [thread overview]
Message-ID: <20080421074240.GA1938@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20080421013551.GA25960@havoc.gtf.org>
On Sun, Apr 20, 2008 at 09:35:51PM -0400, Jeff Garzik wrote:
> diff --git a/arch/arm/mach-integrator/time.c b/arch/arm/mach-integrator/time.c
> index 5278f58..5235f64 100644
> --- a/arch/arm/mach-integrator/time.c
> +++ b/arch/arm/mach-integrator/time.c
> @@ -125,7 +125,7 @@ static int rtc_probe(struct amba_device *dev, void *id)
> xtime.tv_sec = __raw_readl(rtc_base + RTC_DR);
>
> ret = request_irq(dev->irq[0], arm_rtc_interrupt, IRQF_DISABLED,
> - "rtc-pl030", dev);
> + "rtc-pl030", NULL);
> if (ret)
> goto map_out;
>
BTW, if you're removing the dev_id argument from request_irq(), that
also needs to happen for the corresponding free_irq() calls.
arch/arm/mach-integrator/time.c does:
free_irq(dev->irq[0], dev);
and these are untouched.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2008-04-21 7:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-21 1:35 [git patches] minor irq handler cleanups Jeff Garzik
2008-04-21 7:42 ` Russell King [this message]
2008-04-21 8:18 ` Jeff Garzik
2008-04-21 23:00 ` Linus Torvalds
2008-04-22 0:29 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080421074240.GA1938@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=cooloney@kernel.org \
--cc=davem@davemloft.net \
--cc=galak@kernel.crashing.org \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=jeff@garzik.org \
--cc=kernel@wantstofly.org \
--cc=kkeil@suse.de \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox