From: Rusty Russell <rusty@rustcorp.com.au>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: [PATCH 1/6] cast_if_type: allow macros functions which take more than one type.
Date: Mon, 21 Apr 2008 09:00:16 +1000 [thread overview]
Message-ID: <200804210900.16242.rusty@rustcorp.com.au> (raw)
In-Reply-To: <200804210859.00080.rusty@rustcorp.com.au>
To create functions which can take two types, but still warn on any
other types, we need a way of casting one type and no others.
To make things more complex, it should correctly handle function args,
NULL, and be usable in initializers. __builtin_choose_expr was
introduced in gcc 3.1 (kernel needs >= 3.2 anyway).
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
---
include/linux/compiler-gcc.h | 19 +++++++++++++++++++
include/linux/compiler-intel.h | 2 ++
2 files changed, 21 insertions(+)
diff -r bde8a949d956 include/linux/compiler-gcc.h
--- a/include/linux/compiler-gcc.h Mon Apr 07 15:27:30 2008 +1000
+++ b/include/linux/compiler-gcc.h Mon Apr 07 16:19:49 2008 +1000
@@ -53,3 +53,22 @@
#define noinline __attribute__((noinline))
#define __attribute_const__ __attribute__((__const__))
#define __maybe_unused __attribute__((unused))
+
+/**
+ * cast_if_type - allow an alternate type
+ * @expr: the expression to optionally cast
+ * @oktype: the type to allow.
+ * @desttype: the type to cast to.
+ *
+ * This is used to accept a particular alternate type for an expression:
+ * because any other types will not be cast, they will cause a warning as
+ * normal.
+ *
+ * Note that the unnecessary trinary forces functions to devolve into
+ * function pointers as users expect, but means @expr must be a pointer or
+ * integer.
+ */
+#define cast_if_type(expr, oktype, desttype) \
+ __builtin_choose_expr(__builtin_types_compatible_p(typeof(1?(expr):0),\
+ oktype), \
+ (desttype)(expr), (expr))
diff -r bde8a949d956 include/linux/compiler-intel.h
--- a/include/linux/compiler-intel.h Mon Apr 07 15:27:30 2008 +1000
+++ b/include/linux/compiler-intel.h Mon Apr 07 16:19:49 2008 +1000
@@ -29,3 +29,5 @@
#endif
#define uninitialized_var(x) x
+
+#define cast_if_type(expr, oktype, desttype) ((desttype)(expr))
next prev parent reply other threads:[~2008-04-20 23:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-20 22:58 [PATCH 0/6] typesafe callbacks Rusty Russell
2008-04-20 23:00 ` Rusty Russell [this message]
2008-04-20 23:01 ` [PATCH 2/6] typesafe_cb: wrappers for " Rusty Russell
2008-04-20 23:05 ` [PATCH 3/6] typesafe: Convert stop_machine Rusty Russell
2008-04-20 23:07 ` [PATCH 4/6] typesafe: kthread_create and kthread_run Rusty Russell
2008-04-20 23:09 ` [PATCH 5/6] typesafe: request_irq and devm_request_irq Rusty Russell
2008-04-20 23:10 ` [PATCH 6/6] typesafe: TIMER_INITIALIZER and setup_timer Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804210900.16242.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).