From: Joel Becker <Joel.Becker@oracle.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: Mark Fasheh <mfasheh@suse.com>,
ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] make struct ocfs2_control_device static
Date: Mon, 21 Apr 2008 03:01:53 -0700 [thread overview]
Message-ID: <20080421100153.GA7059@ca-server1.us.oracle.com> (raw)
In-Reply-To: <20080421084926.GS26897@cs181133002.pp.htv.fi>
On Mon, Apr 21, 2008 at 11:49:26AM +0300, Adrian Bunk wrote:
> This patch makes the needlessly global struct ocfs2_control_device
> static.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
Acked-by: Joel Becker <joel.becker@oracle.com>
>
> ---
> d8837f8ed79bc615105e5ca2724c3d22c9f26089 diff --git a/fs/ocfs2/stack_user.c b/fs/ocfs2/stack_user.c
> index 7428663..b503772 100644
> --- a/fs/ocfs2/stack_user.c
> +++ b/fs/ocfs2/stack_user.c
> @@ -635,7 +635,7 @@ static const struct file_operations ocfs2_control_fops = {
> .owner = THIS_MODULE,
> };
>
> -struct miscdevice ocfs2_control_device = {
> +static struct miscdevice ocfs2_control_device = {
> .minor = MISC_DYNAMIC_MINOR,
> .name = "ocfs2_control",
> .fops = &ocfs2_control_fops,
>
--
Life's Little Instruction Book #356
"Be there when people need you."
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2008-04-21 10:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-21 8:49 [2.6 patch] make struct ocfs2_control_device static Adrian Bunk
2008-04-21 10:01 ` Joel Becker [this message]
2008-04-21 17:43 ` Mark Fasheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080421100153.GA7059@ca-server1.us.oracle.com \
--to=joel.becker@oracle.com \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mfasheh@suse.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox