* [2.6 patch] make struct ocfs2_control_device static
@ 2008-04-21 8:49 Adrian Bunk
2008-04-21 10:01 ` Joel Becker
2008-04-21 17:43 ` Mark Fasheh
0 siblings, 2 replies; 3+ messages in thread
From: Adrian Bunk @ 2008-04-21 8:49 UTC (permalink / raw)
To: Joel Becker, Mark Fasheh; +Cc: ocfs2-devel, linux-kernel
This patch makes the needlessly global struct ocfs2_control_device
static.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
d8837f8ed79bc615105e5ca2724c3d22c9f26089 diff --git a/fs/ocfs2/stack_user.c b/fs/ocfs2/stack_user.c
index 7428663..b503772 100644
--- a/fs/ocfs2/stack_user.c
+++ b/fs/ocfs2/stack_user.c
@@ -635,7 +635,7 @@ static const struct file_operations ocfs2_control_fops = {
.owner = THIS_MODULE,
};
-struct miscdevice ocfs2_control_device = {
+static struct miscdevice ocfs2_control_device = {
.minor = MISC_DYNAMIC_MINOR,
.name = "ocfs2_control",
.fops = &ocfs2_control_fops,
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [2.6 patch] make struct ocfs2_control_device static
2008-04-21 8:49 [2.6 patch] make struct ocfs2_control_device static Adrian Bunk
@ 2008-04-21 10:01 ` Joel Becker
2008-04-21 17:43 ` Mark Fasheh
1 sibling, 0 replies; 3+ messages in thread
From: Joel Becker @ 2008-04-21 10:01 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Mark Fasheh, ocfs2-devel, linux-kernel
On Mon, Apr 21, 2008 at 11:49:26AM +0300, Adrian Bunk wrote:
> This patch makes the needlessly global struct ocfs2_control_device
> static.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
Acked-by: Joel Becker <joel.becker@oracle.com>
>
> ---
> d8837f8ed79bc615105e5ca2724c3d22c9f26089 diff --git a/fs/ocfs2/stack_user.c b/fs/ocfs2/stack_user.c
> index 7428663..b503772 100644
> --- a/fs/ocfs2/stack_user.c
> +++ b/fs/ocfs2/stack_user.c
> @@ -635,7 +635,7 @@ static const struct file_operations ocfs2_control_fops = {
> .owner = THIS_MODULE,
> };
>
> -struct miscdevice ocfs2_control_device = {
> +static struct miscdevice ocfs2_control_device = {
> .minor = MISC_DYNAMIC_MINOR,
> .name = "ocfs2_control",
> .fops = &ocfs2_control_fops,
>
--
Life's Little Instruction Book #356
"Be there when people need you."
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [2.6 patch] make struct ocfs2_control_device static
2008-04-21 8:49 [2.6 patch] make struct ocfs2_control_device static Adrian Bunk
2008-04-21 10:01 ` Joel Becker
@ 2008-04-21 17:43 ` Mark Fasheh
1 sibling, 0 replies; 3+ messages in thread
From: Mark Fasheh @ 2008-04-21 17:43 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Joel Becker, ocfs2-devel, linux-kernel
On Mon, Apr 21, 2008 at 11:49:26AM +0300, Adrian Bunk wrote:
> This patch makes the needlessly global struct ocfs2_control_device
> static.
This and the following two patches are in ocfs2.git now, thanks Adrian.
--Mark
--
Mark Fasheh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-04-21 17:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-21 8:49 [2.6 patch] make struct ocfs2_control_device static Adrian Bunk
2008-04-21 10:01 ` Joel Becker
2008-04-21 17:43 ` Mark Fasheh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox