From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760098AbYDUMhU (ORCPT ); Mon, 21 Apr 2008 08:37:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756511AbYDUMgQ (ORCPT ); Mon, 21 Apr 2008 08:36:16 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:52816 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759897AbYDUMgP (ORCPT ); Mon, 21 Apr 2008 08:36:15 -0400 Date: Mon, 21 Apr 2008 14:35:54 +0200 From: Ingo Molnar To: Roland McGrath Cc: Thomas Gleixner , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] x86 signals: lift flags diddling code Message-ID: <20080421123554.GC9554@elte.hu> References: <20080419212654.9971827037C@magilla.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080419212654.9971827037C@magilla.localdomain> User-Agent: Mutt/1.5.17 (2007-11-01) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: 0.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=0.5 required=5.9 tests=BAYES_40 autolearn=no SpamAssassin version=3.2.3 0.5 BAYES_40 BODY: Bayesian spam probability is 20 to 40% [score: 0.2921] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Roland McGrath wrote: > This lifts the code diddling the TF and DF bits for signal handler > setup out of the several places copying the same code into the one > place that calls them all. There is no change in what it does. > > I also separated the recently-added DF bit clearing from the TF > diddling. The compiler turns them back into one instruction anyway. > The tossing in of DF to the same line of code with no new comments was > a bit more arcane than seems wise. thanks Roland, applied. Ingo