Re: Voyager phys_cpu_present_map compile error

Pavel Machek
2008-04-26T19:33:06Z

Hi!

> > > > > > Who said that Voyager won't boot?
> > > > >
> > > > > Adrian, you build Voyager kernels so just try to boot it once on
> > > > > your PC and watch the show ...
> > > >
> > > > Ingo, an ia64 kernel also won't boot on my computer, and I'll
> > > > still compile test my patches for ia64 ...
> > >
> > > dont be silly... the ia64 kernel is not under arch/x86, it's not
> > > even the same instruction format. Voyager runs on x86 CPUs and is
> > > part of the x86 architecture tree.
> >
> > Your point is?
>
> my point is what i said and which you apparently did not understand:
>
> | Adrian, could you please remove it from your config testset as well?
> | If a user enables that config option it wont boot anyway so it's not a
> | problem in practice.
>
> > I'm compile testing 22 architectures (especially when sending my own
> > patches), and whether a kernel would boot on my computer doesn't make
> > any difference.
>
> a user wont 'accidentally' install a crosscompiler toolchain to create
> an unbootable kernel...

I guess Adrian is trying to say:

'That code is in tree, so it should compile and run. He can't verify
it runs, but he's trying to make sure it at least compiles.'

For 'normal' users it is not a problem.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html