Re: Voyager phys_cpu_present_map compile error

Ingo Molnar
2008-04-21T20:04:06Z

* James Bottomley <James.Bottomley@HansenPartnership.com> wrote:

> > > i ended up excluding Voyager configs from our test space some time
> > > ago (and VISWS as well - there's one more visws fix in x86.git),
> > > that's how this broke. These subarchitectures seem not to be used
> > > at all and the code wont boot on normal PCs. We could mark it
> > > BROKEN but the fix seems simple in any case.
>
> I did actually try to avoid these problems by booting the -mc tree on
> voyager, but I note that none of these issues showed up in that tree
> the last time I did this (admittedly about 3 weeks ago because of
> various conferences etc).

btw., any chance to turn it into a quirk space thing? Voyagers are
almost-PCs, right? Most of the Voyager specialities appears to be
abstracted away already via smp_ops. I.e. we could have Voyager support
in a plain x86 kernel, if CONFIG_X86_VOYAGER is turned on.

quirks we can let survive almost forever - we've still got the math-emu
code for example. It's the subarch code we'd like to eliminate
eventually. (there are much better abstractions for achieving the same
thing: quirks and the genapic code)

OTOH, i just had a look at it, and it seems a rather special thing - it
tries to do like a PC but without actually being a PC. Almost as if it
had no or just a little bit of BIOS - the whole Voyager kernel seems to
run on the bare metal. Not much point in upsetting that code base i
suspect.

let us know if you run into any difficulties with making it to boot
again ... nothing truly fundamental should have changed to break it,
other that this moving around of SMP code.

Ingo