Re: Voyager phys_cpu_present_map compile error

Adrian Bunk
2008-04-21T13:34:23Z

On Mon, Apr 21, 2008 at 02:00:54PM +0200, Ingo Molnar wrote:
>
> * Adrian Bunk <bunk@kernel.org> wrote:
>
> > I shouldn't send bug reports at 3 in the morning...
> >
> > Attached is the .config for both Voyager build errors I reported.
>
> thanks, the three patches below should fix it.
>...
> Ingo
>...
> --- linux-x86.q.orig/arch/x86/kernel/setup.c
> +++ linux-x86.q/arch/x86/kernel/setup.c
> @@ -21,8 +21,10 @@ EXPORT_SYMBOL(boot_cpu_physical_apicid);
> DEFINE_PER_CPU(u16, x86_cpu_to_apicid) = BAD_APICID;
> EXPORT_PER_CPU_SYMBOL(x86_cpu_to_apicid);
>
> +#ifndef CONFIG_X86_VOYAGER
> /* Bitmask of physically existing CPUs */
> physid_mask_t phys_cpu_present_map;
> +#endif
>...

Alexey noted that phys_cpu_present_map for Voyager and !Voyager also
have different types and suggested to make the Voyager one static
instead (additional renaming of the Voyager one also makes sense).

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed