Re: Voyager phys_cpu_present_map compile error

Ingo Molnar
2008-04-21T19:55:47Z

* H. Peter Anvin <hpa@zytor.com> wrote:

>> thanks, the three patches below should fix it.
>>
>> i ended up excluding Voyager configs from our test space some time
>> ago (and VISWS as well - there's one more visws fix in x86.git),
>> that's how this broke. These subarchitectures seem not to be used at
>> all and the code wont boot on normal PCs. We could mark it BROKEN but
>> the fix seems simple in any case.
>
> I talked to jejb about this, and pretty much the consensus was that if
> it breaks, mark it BROKEN, and let him come back and catch up. Under
> those conditions, I'm willing to keep it in the tree.

sure - but no need to be rude and mark it BROKEN when we've got this
much better tool named "email". BROKEN is really just for cases where
there's no-one willing to fix things.

> VISWS is another matter. It's entirely possible I have the only
> remaining VISWS in my garage; we have at least not been able to locate
> another. Not that we have tried all that hard.
>
> If there are no VISWS' left, we should just unload the code.

ok, but there we should first mark it BROKEN, and after 1-2 kernel
releases remove it so that there's adequate notice.

Ingo