Re: Voyager phys_cpu_present_map compile error

Adrian Bunk
2008-04-21T20:10:29Z

On Mon, Apr 21, 2008 at 09:51:48PM +0200, Ingo Molnar wrote:
>
> * James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
>
> > > thanks, the three patches below should fix it.
> > >
> > > i ended up excluding Voyager configs from our test space some time
> > > ago (and VISWS as well - there's one more visws fix in x86.git),
> > > that's how this broke. These subarchitectures seem not to be used at
> > > all and the code wont boot on normal PCs. We could mark it BROKEN
> > > but the fix seems simple in any case.
> >
> > The voyager pieces of this code look fine to me. I can't test at the
> > moment because we're having the carpets cleaned and I can't get down
> > into the cellar where the systems are, but I'll do so shortly.
>
> ok, that's good enough - that's why i excluded it from the auto-qa
> test-space as well. Adrian, could you please remove it from your config
> testset as well? If a user enables that config option it wont boot
> anyway so it's not a problem in practice.

Who said that Voyager won't boot?

And I'm the first to remove non-working code, but as long as we
ship it it should be in the best possible state.

> Ingo

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed