From: Andy Whitcroft <apw@shadowen.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Randy Dunlap <rdunlap@xenotime.net>,
Joel Schopp <jschopp@austin.ibm.com>,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: False positive in checkpatch (2.6.25)
Date: Tue, 22 Apr 2008 09:05:47 +0100 [thread overview]
Message-ID: <20080422080547.GC26446@shadowen.org> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0804171530070.19418-100000@iolanthe.rowland.org>
On Thu, Apr 17, 2008 at 03:33:48PM -0400, Alan Stern wrote:
> ERROR: space prohibited after that '*' (ctx:ExW)
> #15: FILE: drivers/usb/core/driver.c:1544:
> + * when the system suspend started, so we don't want to resume it
> ^
>
> ERROR: Missing Signed-off-by: line(s)
Yes, pretty sure that was triggered by a bug in comment tracking when
it moved into quote tracking. From my testing here it should have been
fixed in v0.17, you have v0.16. Andrew has the change queued up so it
should be on its way to mainline. You can get the latest from the url
below to confirm:
http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/
Thanks for the report.
-apw
next prev parent reply other threads:[~2008-04-22 8:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-17 19:33 False positive in checkpatch (2.6.25) Alan Stern
2008-04-22 8:05 ` Andy Whitcroft [this message]
2008-04-22 14:55 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080422080547.GC26446@shadowen.org \
--to=apw@shadowen.org \
--cc=jschopp@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox