From: "Uwe Kleine-König" <Uwe.Kleine-Koenig@digi.com>
To: Ben Nizette <bn@niasdigital.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: UIO: Implement a UIO interface for the SMX Cryptengine
Date: Tue, 22 Apr 2008 11:32:13 +0200 [thread overview]
Message-ID: <20080422093213.GA27126@digi.com> (raw)
In-Reply-To: <1208173181.3351.63.camel@moss.renham>
Hello,
Ben Nizette wrote:
>
> [putting lkml back in CC]
>
> On Mon, 2008-04-14 at 12:08 +0200, Uwe Kleine-König wrote:
>
> > The line "depends on UIO" isn't needed (anymore) because the whole
> > config item is located in a "if UIO"/"endif".
>
> Right, just saw your patch fly by. Given mine's been taken up by gregkh
> already I was kinda hoping someone further up the tree would end up
> fixing it. If not I can of course rebase and resend.
Your patch is in Linus' tree in the meantime and mine is not (yet). I
suggest to prepare a patch such that both drivers share some code after
my driver has hit mainline.
> > The "default n" isn't necessary because that's the default anyhow.
>
> Eh, I like to be explicit.
I expect this to be cleaned up later by someone à la:
git log -E --grep='([Rr]emove|useless|unnecessary).*default n\>'
:-)
Best regards
Uwe
--
Uwe Kleine-König, Software Engineer
Digi International GmbH Branch Breisach, Küferstrasse 8, 79206 Breisach, Germany
Tax: 315/5781/0242 / VAT: DE153662976 / Reg. Amtsgericht Dortmund HRB 13962
prev parent reply other threads:[~2008-04-22 9:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080414100848.GA19369@digi.com>
2008-04-14 11:39 ` UIO: Implement a UIO interface for the SMX Cryptengine Ben Nizette
2008-04-22 9:32 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080422093213.GA27126@digi.com \
--to=uwe.kleine-koenig@digi.com \
--cc=bn@niasdigital.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox