Re: UIO: Implement a UIO interface for the SMX Cryptengine

Re: UIO: Implement a UIO interface for the SMX Cryptengine

[Ben Nizette]

[putting lkml back in CC]

On Mon, 2008-04-14 at 12:08 +0200, Uwe Kleine-König wrote:

> The line "depends on UIO" isn't needed (anymore) because the whole
> config item is located in a "if UIO"/"endif".

Right, just saw your patch fly by.  Given mine's been taken up by gregkh
already I was kinda hoping someone further up the tree would end up
fixing it.  If not I can of course rebase and resend.

> 
> The "default n" isn't necessary because that's the default anyhow.

Eh, I like to be explicit.

> 
> I didn't look deeper into that patch, but it might be possible to
share
> code with my patch

Indeed, I quite like your patch.  I spend a fair bit of time on the
AVRFreaks AVR32 support community and I can see a great need for what
you've done.  That said, if HJK/ GregKH don't object I think I'll leave
mine pretty much as-is; having a device-specific ISR in platform code
just doesn't quite sit smooth with me :-)

Thanks!
	--Ben.

Re: UIO: Implement a UIO interface for the SMX Cryptengine

[Uwe Kleine-König]

Hello,

Ben Nizette wrote:
> 
> [putting lkml back in CC]
> 
> On Mon, 2008-04-14 at 12:08 +0200, Uwe Kleine-König wrote:
> 
> > The line "depends on UIO" isn't needed (anymore) because the whole
> > config item is located in a "if UIO"/"endif".
> 
> Right, just saw your patch fly by.  Given mine's been taken up by gregkh
> already I was kinda hoping someone further up the tree would end up
> fixing it.  If not I can of course rebase and resend.
Your patch is in Linus' tree in the meantime and mine is not (yet).  I
suggest to prepare a patch such that both drivers share some code after
my driver has hit mainline.
 
> > The "default n" isn't necessary because that's the default anyhow.
> 
> Eh, I like to be explicit.
I expect this to be cleaned up later by someone à la:

	git log -E --grep='([Rr]emove|useless|unnecessary).*default n\>'

:-)

Best regards
Uwe

-- 
Uwe Kleine-König, Software Engineer
Digi International GmbH Branch Breisach, Küferstrasse 8, 79206 Breisach, Germany
Tax: 315/5781/0242 / VAT: DE153662976 / Reg. Amtsgericht Dortmund HRB 13962