From: Ingo Molnar <mingo@elte.hu>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: akpm@osdl.org, "H. Peter Anvin" <hpa@zytor.com>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Steven Rostedt <rostedt@goodmis.org>,
"Frank Ch. Eigler" <fche@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix x86_64 page fault scheduler race
Date: Tue, 22 Apr 2008 15:26:14 +0200 [thread overview]
Message-ID: <20080422132614.GC7311@elte.hu> (raw)
In-Reply-To: <20080422132151.GA32120@Krystal>
* Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> wrote:
> You are right in that x86_64 does not seems to play as safely as
> x86_32 on this matter; it uses current->mm. Probably it shouldn't
> assume "current" is valid. Actually, I don't see where x86_64 disables
> interrupts around __switch_to, so this would seem to be a race
> condition. Or have I missed something ?
the scheduler disables interrupts around __switch_to(). (x86 does not
set __ARCH_WANT_INTERRUPTS_ON_CTXSW)
Ingo
next prev parent reply other threads:[~2008-04-22 13:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-22 13:21 [PATCH] Fix x86_64 page fault scheduler race Mathieu Desnoyers
2008-04-22 13:26 ` Ingo Molnar [this message]
2008-04-22 14:06 ` Mathieu Desnoyers
2008-04-22 14:19 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080422132614.GC7311@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=fche@redhat.com \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox