From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Jeff Chua <jeff.chua.linux@gmail.com>, Greg KH <gregkh@suse.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [Broken] PCI: clean up resource alignment management
Date: Tue, 22 Apr 2008 15:51:56 -0700 [thread overview]
Message-ID: <200804221551.56502.jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <alpine.LFD.1.10.0804221510420.2779@woody.linux-foundation.org>
On Tuesday, April 22, 2008 3:13 pm Linus Torvalds wrote:
> On Tue, 22 Apr 2008, Linus Torvalds wrote:
> > (In fact, I think cardbus bridges have a much more flexible alignment
> > than that size thing, and can be aligned at finer granularity, but I
> > forget the exact details, and since we didn't add a special "alignment"
> > field, we can't take advantage of it anyway).
>
> Yeah, I double-checked: the IO alignment is 4 bytes, the MEM alignment is
> 4k.
>
> So if we had a separate alignment word we could use that, but in the
> meantime I think IORESOURCE_SIZEALIGN is good enough, and a bit more
> readable than the STARTALIGN thing.
>
> Now we just need to have somebody test it. It turns out that I no longer
> have any Cardbus cards, since my laptops now all have built-in wireless.
> Boo hiss for me.
I may be in the same boat, I'll have to dig around and see if I have any...
That said, I think an explicit alignment field would make things even cleaner
(and like you said allow us to take advantage of bus specific alignment
better).
Jesse
next prev parent reply other threads:[~2008-04-22 22:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <b6a2187b0804220943l26f7b441sb5a7309dff0e84dc@mail.gmail.com>
2008-04-22 16:44 ` [Broken] PCI: clean up resource alignment management Jeff Chua
2008-04-22 17:25 ` Linus Torvalds
2008-04-22 21:40 ` Ivan Kokshaysky
2008-04-22 21:59 ` Linus Torvalds
2008-04-22 22:13 ` Linus Torvalds
2008-04-22 22:51 ` Jesse Barnes [this message]
2008-04-23 1:06 ` Linus Torvalds
2008-04-23 1:05 ` Jeff Chua
2008-04-23 1:26 ` Linus Torvalds
2008-04-23 1:46 ` Jeff Chua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804221551.56502.jbarnes@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=gregkh@suse.de \
--cc=ink@jurassic.park.msu.ru \
--cc=jeff.chua.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox