From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933860AbYDWA3R (ORCPT ); Tue, 22 Apr 2008 20:29:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756739AbYDWA3D (ORCPT ); Tue, 22 Apr 2008 20:29:03 -0400 Received: from netops-testserver-3-out.sgi.com ([192.48.171.28]:48834 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756790AbYDWA3B (ORCPT ); Tue, 22 Apr 2008 20:29:01 -0400 Date: Tue, 22 Apr 2008 19:28:49 -0500 From: Jack Steiner To: Robin Holt Cc: Andrea Arcangeli , Christoph Lameter , Nick Piggin , Peter Zijlstra , kvm-devel@lists.sourceforge.net, Kanoj Sarcar , Roland Dreier , Steve Wise , linux-kernel@vger.kernel.org, Avi Kivity , linux-mm@kvack.org, general@lists.openfabrics.org, Hugh Dickins , akpm@linux-foundation.org, Rusty Russell Subject: Re: [PATCH 01 of 12] Core of mmu notifiers Message-ID: <20080423002848.GA32618@sgi.com> References: <20080422223545.GP24536@duo.random> <20080422230727.GR30298@sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080422230727.GR30298@sgi.com> User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 22, 2008 at 06:07:27PM -0500, Robin Holt wrote: > > The only other change I did has been to move mmu_notifier_unregister > > at the end of the patchset after getting more questions about its > > reliability and I documented a bit the rmmod requirements for > > ->release. we'll think later if it makes sense to add it, nobody's > > using it anyway. > > XPMEM is using it. GRU will be as well (probably already does). Yeppp. The GRU driver unregisters the notifier when all GRU mappings are unmapped. I could make it work either way - either with or without an unregister function. However, unregister is the most logical action to take when all mappings have been destroyed. --- jack