Re: [patch] softlockup: fix false positives on nohz if CPU is 100% idle for more than 60 seconds

Ingo Molnar
2008-04-23T13:37:25Z

* David Miller <davem@davemloft.net> wrote:

> > It may take some time, as each test run the verify the existence of
> > the problem takes several minutes.
>
> Ok, Ingo, none of your patches fix even the initial buggy changeset,
> for reference:

as a temporary workaround please try the patch below, until we can
reproduce and fix the bug.

Ingo

------------------------------->
Subject: softlockup: nohz workaround
From: Ingo Molnar <mingo@elte.hu>
Date: Wed Apr 23 15:19:32 CEST 2008

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
kernel/softlockup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux/kernel/softlockup.c
===================================================================
--- linux.orig/kernel/softlockup.c
+++ linux/kernel/softlockup.c
@@ -245,7 +245,7 @@ static int watchdog(void *__bind_cpu)
*/
while (!kthread_should_stop()) {
touch_softlockup_watchdog();
- schedule();
+ schedule_timeout(softlockup_thresh/2);

if (kthread_should_stop())
break;