From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
akpm@goodmis.org, Soeren Sandmann Pedersen <sandmann@redhat.com>,
Pekka Paalanen <pq@iki.fi>
Subject: Re: [PATCH] ftrace: fix setting of pos in read_pipe
Date: Wed, 23 Apr 2008 11:52:20 +0200 [thread overview]
Message-ID: <20080423095220.GA23908@elte.hu> (raw)
In-Reply-To: <Pine.LNX.4.58.0804222205110.32718@gandalf.stny.rr.com>
* Steven Rostedt <rostedt@goodmis.org> wrote:
> In resetting the iterator in read_pipe, the reset of pos was
> postitioned in the wrong location with respect to the memset
> operation. The current code sets pos, incorrectly, to zero.
applied - but what is missing from your changelog is effects of this
bug. When testers check lkml they might be interested in that
information. Is the result of this bug an incorrect trace_pipe output?
(double entries, or missed entries?)
Ingo
next prev parent reply other threads:[~2008-04-23 9:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-23 2:08 [PATCH] ftrace: fix setting of pos in read_pipe Steven Rostedt
2008-04-23 9:52 ` Ingo Molnar [this message]
2008-04-23 12:06 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080423095220.GA23908@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=pq@iki.fi \
--cc=rostedt@goodmis.org \
--cc=sandmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox