From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756277AbYDWJ6m (ORCPT ); Wed, 23 Apr 2008 05:58:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756025AbYDWJwi (ORCPT ); Wed, 23 Apr 2008 05:52:38 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:40259 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756015AbYDWJwh (ORCPT ); Wed, 23 Apr 2008 05:52:37 -0400 Date: Wed, 23 Apr 2008 11:52:20 +0200 From: Ingo Molnar To: Steven Rostedt Cc: LKML , Peter Zijlstra , akpm@goodmis.org, Soeren Sandmann Pedersen , Pekka Paalanen Subject: Re: [PATCH] ftrace: fix setting of pos in read_pipe Message-ID: <20080423095220.GA23908@elte.hu> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Steven Rostedt wrote: > In resetting the iterator in read_pipe, the reset of pos was > postitioned in the wrong location with respect to the memset > operation. The current code sets pos, incorrectly, to zero. applied - but what is missing from your changelog is effects of this bug. When testers check lkml they might be interested in that information. Is the result of this bug an incorrect trace_pipe output? (double entries, or missed entries?) Ingo