Re: [PATCH 0/2] Input: adbhid - restore_capslock_events fixes

Dmitry Torokhov
2008-04-25T15:10:00Z

Hi Rodney,

On Wed, Apr 23, 2008 at 12:14:16PM +0200, Rodney Lorrimar wrote:
> Hi Dmitry,
>
> Would you consider these for review and inclusion in the input tree?
>
> They fix 2 out of 3 problems I know of in the simulation of capslock
> up/down key events on Apple laptop keyboards.

They look reasonable, I will apply them, thank you.

> The third problem - that
> sometimes the capslock key gets stuck down - I haven't looked at
> properly yet, but I know that the "capslock key up" packet is never
> received by adbhid_keyboard_input so the problem is in adb.c or
> via-pmu.c, or possibly the hardware never sends the event at all.
>
> Pavel Machek suggested removing the parameter, and I would do this
> after fixing the third problem. This would probably happen after the
> once-or-twice-a-day event of stuck capslock annoys me enough to have a
> deeper look.
>

OK.

--
Dmitry