From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757554AbYDWVCs (ORCPT ); Wed, 23 Apr 2008 17:02:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754400AbYDWVCf (ORCPT ); Wed, 23 Apr 2008 17:02:35 -0400 Received: from e35.co.us.ibm.com ([32.97.110.153]:48460 "EHLO e35.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754355AbYDWVCd (ORCPT ); Wed, 23 Apr 2008 17:02:33 -0400 Date: Wed, 23 Apr 2008 14:02:27 -0700 From: "Paul E. McKenney" To: Oleg Nesterov Cc: Andrew Morton , hch@lst.de, davem@davemloft.net, peterz@infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0.01/1] hlist_for_each_entry_xxx: kill the "pos" argument Message-ID: <20080423210227.GC8746@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <20080421151443.GA29670@tv-sign.ru> <20080422013302.GJ9153@linux.vnet.ibm.com> <20080422090921.GA130@tv-sign.ru> <20080422064030.82b37fd9.akpm@linux-foundation.org> <20080422162337.GB19909@tv-sign.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080422162337.GB19909@tv-sign.ru> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 22, 2008 at 08:23:37PM +0400, Oleg Nesterov wrote: > On 04/22, Andrew Morton wrote: > > > > > On Tue, 22 Apr 2008 13:09:21 +0400 Oleg Nesterov wrote: > > > On 04/21, Paul E. McKenney wrote: > > > > > > > > Might it be better to do this in two > > > > phases to allow these patches to be applied incrementally? > > > > > > > > 1. Change all to "obsolete" __hlist_for_each_entry_xxx(). > > > > > > > > 2. Incrementally change to hlist_for_each_entry_xxx(), removing > > > > the extra variable where possible. > > > > > > Yes sure. Actually this was my initial plan. > > > > > > Andrew, which way do you prefer? > > > > Neither ;) > > > > The smoothest transition would come by adding new macros with new names, > > then migrating all callers over then removing the old macros. > > OK, will do, but.... > > > Preferably after leaving the old, unused macros in place for a kernel > > cycle, but there's not much value in that unless we can make them emil > > warnings when used, which isn't completely trivial. > > we can make > > static inline void __deprecated nop_for_hlist_for_each_entry(void) {} > > and insert it into the old macro's body > > > Plus there is no sensible new name which we can use. Maybe you can think > > of one, in which case that'd be a nice way to go. > > Ah. But this _is_ the problem. There is no a good name for hlist_for_each_entry() > except of course hlist_for_each_entry. hlist_for_every_entry()? (Sorry, couldn't resist...) Thanx, Paul > Well. I'll use hnode_for_each_entry_xxx(), but please let me know if you > change your mind ;) > > Oleg. >