* [PATCH] ARM: am79c961a: platform_get_irq() may return signed unnoticed
@ 2008-04-23 21:44 Roel Kluin
2008-04-23 21:49 ` [PATCH 2/2] ARM: ax88796: " Roel Kluin
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Roel Kluin @ 2008-04-23 21:44 UTC (permalink / raw)
To: rmk, Linux-arm; +Cc: lkml
dev->irq is unsigned, platform_get_irq() may return signed unnoticed
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/drivers/net/arm/am79c961a.c b/drivers/net/arm/am79c961a.c
index ba6bd03..a637910 100644
--- a/drivers/net/arm/am79c961a.c
+++ b/drivers/net/arm/am79c961a.c
@@ -693,11 +693,15 @@ static int __init am79c961_probe(struct platform_device *pdev)
* done by the ether bootp loader.
*/
dev->base_addr = res->start;
- dev->irq = platform_get_irq(pdev, 0);
+ ret = platform_get_irq(pdev, 0);
- ret = -ENODEV;
- if (dev->irq < 0)
+ if (ret < 0) {
+ ret = -ENODEV;
goto nodev;
+ }
+ dev->irq = ret;
+
+ ret = -ENODEV;
if (!request_region(dev->base_addr, 0x18, dev->name))
goto nodev;
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] ARM: ax88796: platform_get_irq() may return signed unnoticed
2008-04-23 21:44 [PATCH] ARM: am79c961a: platform_get_irq() may return signed unnoticed Roel Kluin
@ 2008-04-23 21:49 ` Roel Kluin
2008-04-28 20:09 ` Russell King - ARM Linux
2008-04-24 6:11 ` [PATCH] ARM: am79c961a: " Uwe Kleine-König
2008-04-29 5:59 ` Jeff Garzik
2 siblings, 1 reply; 5+ messages in thread
From: Roel Kluin @ 2008-04-23 21:49 UTC (permalink / raw)
To: rmk, Linux-arm; +Cc: lkml
similarly,
---
dev->irq is unsigned, platform_get_irq() may return signed unnoticed
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/drivers/net/ax88796.c b/drivers/net/ax88796.c
index 194949a..26a735a 100644
--- a/drivers/net/ax88796.c
+++ b/drivers/net/ax88796.c
@@ -838,10 +838,10 @@ static int ax_probe(struct platform_device *pdev)
/* find the platform resources */
- dev->irq = platform_get_irq(pdev, 0);
- if (dev->irq < 0) {
+ ret = platform_get_irq(pdev, 0);
+ dev->irq = ret;
+ if (ret < 0) {
dev_err(&pdev->dev, "no IRQ specified\n");
- ret = -ENXIO;
goto exit_mem;
}
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: am79c961a: platform_get_irq() may return signed unnoticed
2008-04-23 21:44 [PATCH] ARM: am79c961a: platform_get_irq() may return signed unnoticed Roel Kluin
2008-04-23 21:49 ` [PATCH 2/2] ARM: ax88796: " Roel Kluin
@ 2008-04-24 6:11 ` Uwe Kleine-König
2008-04-29 5:59 ` Jeff Garzik
2 siblings, 0 replies; 5+ messages in thread
From: Uwe Kleine-König @ 2008-04-24 6:11 UTC (permalink / raw)
To: Roel Kluin; +Cc: rmk, Linux-arm, lkml
Hello,
Roel Kluin wrote:
> dev->irq is unsigned, platform_get_irq() may return signed unnoticed
>
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
> ---
> diff --git a/drivers/net/arm/am79c961a.c b/drivers/net/arm/am79c961a.c
> index ba6bd03..a637910 100644
> --- a/drivers/net/arm/am79c961a.c
> +++ b/drivers/net/arm/am79c961a.c
> @@ -693,11 +693,15 @@ static int __init am79c961_probe(struct platform_device *pdev)
> * done by the ether bootp loader.
> */
> dev->base_addr = res->start;
> - dev->irq = platform_get_irq(pdev, 0);
> + ret = platform_get_irq(pdev, 0);
>
> - ret = -ENODEV;
> - if (dev->irq < 0)
> + if (ret < 0) {
> + ret = -ENODEV;
> goto nodev;
> + }
> + dev->irq = ret;
> +
> + ret = -ENODEV;
> if (!request_region(dev->base_addr, 0x18, dev->name))
> goto nodev;
For me the change looks fine.
Best regards
Uwe
--
Uwe Kleine-König, Software Engineer
Digi International GmbH Branch Breisach, Küferstrasse 8, 79206 Breisach, Germany
Tax: 315/5781/0242 / VAT: DE153662976 / Reg. Amtsgericht Dortmund HRB 13962
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] ARM: ax88796: platform_get_irq() may return signed unnoticed
2008-04-23 21:49 ` [PATCH 2/2] ARM: ax88796: " Roel Kluin
@ 2008-04-28 20:09 ` Russell King - ARM Linux
0 siblings, 0 replies; 5+ messages in thread
From: Russell King - ARM Linux @ 2008-04-28 20:09 UTC (permalink / raw)
To: Roel Kluin, Ben Dooks; +Cc: Linux-arm, lkml
On Wed, Apr 23, 2008 at 11:49:10PM +0200, Roel Kluin wrote:
> similarly,
At the top of the file, it says:
* Copyright 2005,2007 Simtec Electronics
* Ben Dooks <ben@simtec.co.uk>
So adding Ben.
> ---
> dev->irq is unsigned, platform_get_irq() may return signed unnoticed
>
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
> ---
> diff --git a/drivers/net/ax88796.c b/drivers/net/ax88796.c
> index 194949a..26a735a 100644
> --- a/drivers/net/ax88796.c
> +++ b/drivers/net/ax88796.c
> @@ -838,10 +838,10 @@ static int ax_probe(struct platform_device *pdev)
>
> /* find the platform resources */
>
> - dev->irq = platform_get_irq(pdev, 0);
> - if (dev->irq < 0) {
> + ret = platform_get_irq(pdev, 0);
> + dev->irq = ret;
> + if (ret < 0) {
> dev_err(&pdev->dev, "no IRQ specified\n");
> - ret = -ENXIO;
> goto exit_mem;
> }
>
>
>
> -------------------------------------------------------------------
> List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
> FAQ: http://www.arm.linux.org.uk/mailinglists/faq.php
> Etiquette: http://www.arm.linux.org.uk/mailinglists/etiquette.php
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: am79c961a: platform_get_irq() may return signed unnoticed
2008-04-23 21:44 [PATCH] ARM: am79c961a: platform_get_irq() may return signed unnoticed Roel Kluin
2008-04-23 21:49 ` [PATCH 2/2] ARM: ax88796: " Roel Kluin
2008-04-24 6:11 ` [PATCH] ARM: am79c961a: " Uwe Kleine-König
@ 2008-04-29 5:59 ` Jeff Garzik
2 siblings, 0 replies; 5+ messages in thread
From: Jeff Garzik @ 2008-04-29 5:59 UTC (permalink / raw)
To: Roel Kluin; +Cc: rmk, Linux-arm, lkml
Roel Kluin wrote:
> dev->irq is unsigned, platform_get_irq() may return signed unnoticed
>
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
> ---
> diff --git a/drivers/net/arm/am79c961a.c b/drivers/net/arm/am79c961a.c
> index ba6bd03..a637910 100644
> --- a/drivers/net/arm/am79c961a.c
> +++ b/drivers/net/arm/am79c961a.c
> @@ -693,11 +693,15 @@ static int __init am79c961_probe(struct platform_device *pdev)
> * done by the ether bootp loader.
> */
> dev->base_addr = res->start;
> - dev->irq = platform_get_irq(pdev, 0);
> + ret = platform_get_irq(pdev, 0);
>
> - ret = -ENODEV;
> - if (dev->irq < 0)
> + if (ret < 0) {
> + ret = -ENODEV;
> goto nodev;
> + }
> + dev->irq = ret;
> +
> + ret = -ENODEV;
> if (!request_region(dev->base_addr, 0x18, dev->name))
> goto nodev;
applied
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-04-29 6:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-23 21:44 [PATCH] ARM: am79c961a: platform_get_irq() may return signed unnoticed Roel Kluin
2008-04-23 21:49 ` [PATCH 2/2] ARM: ax88796: " Roel Kluin
2008-04-28 20:09 ` Russell King - ARM Linux
2008-04-24 6:11 ` [PATCH] ARM: am79c961a: " Uwe Kleine-König
2008-04-29 5:59 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox