Re: [PATCH] wireless: rndis_wlan: modparam_workaround_interval is never below 0.

Johannes Berg
2008-04-24T08:57:49Z

[-- Attachment #1: Type: text/plain, Size: 531 bytes --]

On Wed, 2008-04-23 at 22:10 +0200, Roel Kluin wrote:
> priv->param_workaround_interval is unsigned,
> modparam_workaround_interval not.
> the former is never < 0.

> - priv->param_workaround_interval = modparam_workaround_interval;
>
> - if (priv->param_workaround_interval < 0)
> + if (modparam_workaround_interval < 0)
> priv->param_workaround_interval = 500;
> + else
> + priv->param_workaround_interval = modparam_workaround_interval;

Eh, why not make the modparam unsigned and default to 500?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]