* [PATCH 1/6] make module_sect_attrs private to kernel/module.c
@ 2008-04-24 5:01 Rusty Russell
0 siblings, 0 replies; only message in thread
From: Rusty Russell @ 2008-04-24 5:01 UTC (permalink / raw)
To: linux-kernel; +Cc: Jan Beulich
No-one else is using these afaics.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
---
include/linux/module.h | 17 -----------------
kernel/module.c | 16 +++++++++++++++-
2 files changed, 15 insertions(+), 18 deletions(-)
diff -u
--- linux-2.6.25-rc5/include/linux/module.h 2008-03-10 13:24:33.000000000
+0100
+++ 2.6.25-rc5-private-module-sect-attrs/include/linux/module.h 2008-03-04
11:25:28.000000000 +0100
@@ -229,23 +229,6 @@ enum module_state
MODULE_STATE_GOING,
};
-/* Similar stuff for section attributes. */
-struct module_sect_attr
-{
- struct module_attribute mattr;
- char *name;
- unsigned long address;
-};
-
-struct module_sect_attrs
-{
- struct attribute_group grp;
- int nsections;
- struct module_sect_attr attrs[0];
-};
-
-struct module_param_attrs;
-
struct module
{
enum module_state state;
--- linux-2.6.25-rc5/kernel/module.c 2008-03-10 13:24:35.000000000 +0100
+++ 2.6.25-rc5-private-module-sect-attrs/kernel/module.c 2008-03-04
11:26:10.000000000 +0100
@@ -992,6 +992,20 @@ static unsigned long resolve_symbol(Elf_
* J. Corbet <corbet@lwn.net>
*/
#if defined(CONFIG_KALLSYMS) && defined(CONFIG_SYSFS)
+struct module_sect_attr
+{
+ struct module_attribute mattr;
+ char *name;
+ unsigned long address;
+};
+
+struct module_sect_attrs
+{
+ struct attribute_group grp;
+ unsigned int nsections;
+ struct module_sect_attr attrs[0];
+};
+
static ssize_t module_sect_show(struct module_attribute *mattr,
struct module *mod, char *buf)
{
@@ -1002,7 +1016,7 @@ static ssize_t module_sect_show(struct m
static void free_sect_attrs(struct module_sect_attrs *sect_attrs)
{
- int section;
+ unsigned int section;
for (section = 0; section < sect_attrs->nsections; section++)
kfree(sect_attrs->attrs[section].name);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-04-24 5:01 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-24 5:01 [PATCH 1/6] make module_sect_attrs private to kernel/module.c Rusty Russell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox