The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Brandon Philips <bphilips@suse.de>
Cc: Adrian Bunk <bunk@kernel.org>,
	Matthias Schwarzott <zzam@gentoo.org>,
	v4l-dvb-maintainer@linuxtv.org, linux-kernel@vger.kernel.org,
	Patrick Boettcher <pb@linuxtv.org>
Subject: Re: [v4l-dvb-maintainer] no help text for DVB_TUNER_ITD1000
Date: Thu, 24 Apr 2008 23:16:40 -0300	[thread overview]
Message-ID: <20080424231640.3f8f2d9a@gaivota> (raw)
In-Reply-To: <20080425002351.GA19764@plankton>

On Thu, 24 Apr 2008 17:23:51 -0700
Brandon Philips <bphilips@suse.de> wrote:

> On 20:39 Thu 24 Apr 2008, Mauro Carvalho Chehab wrote:
> > I've did a diff between the applied patch and the original ones. It is
> > not easy to compare the diffs manually, since file order changes, but
> > it seems that the other patches are ok.
> 
> interdiff can help find identical patches that just change file order.

Very useful. 

It confirmed that the only two patches with problems are:

v4l_dvb_hg_7571_mt312_cleanup_buffer_variables_of_read_write_functions.patch:
--- b/drivers/media/dvb/frontends/Kconfig
+++ a/drivers/media/dvb/frontends/Kconfig

-config DVB_TUNER_ITD1000
-       tristate "Integrant ITD1000 Zero IF tuner for DVB-S/DSS"
-       depends on DVB_CORE && I2C
-       default m if DVB_FE_CUSTOMISE
-
 comment "Miscellaneous devices"
--- b/drivers/media/dvb/frontends/Makefile
+++ a/drivers/media/dvb/frontends/Makefile
 obj-$(CONFIG_DVB_TUNER_XC5000) += xc5000.o
-obj-$(CONFIG_DVB_TUNER_ITD1000) += itd1000.o

and v4l_dvb_hg_7569_added_support_for_skystar2_rev2_7_and_itd1000_dvb_s_tuner.patch:

only in patch2:
--- oldtree/drivers/media/dvb/frontends/Kconfig 2008-04-14 22:19:41.000000000 -0300
+++ linux/drivers/media/dvb/frontends/Kconfig   2008-04-14 22:19:38.000000000 -0300

+config DVB_TUNER_ITD1000
+       tristate "Integrant ITD1000 Zero IF tuner for DVB-S/DSS"
+       depends on DVB_CORE && I2C
+       default m if DVB_FE_CUSTOMISE
+
 comment "Miscellaneous devices"
only in patch2:
--- oldtree/drivers/media/dvb/frontends/Makefile        2008-04-14 22:19:41.000000000 -0300
+++ linux/drivers/media/dvb/frontends/Makefile  2008-04-14 22:19:38.000000000 -0300
 obj-$(CONFIG_DVB_TUNER_XC5000) += xc5000.o
+obj-$(CONFIG_DVB_TUNER_ITD1000) += itd1000.o

I can't understand what happened by looking on my procedure. It really seems to
be some corruption on -git, maybe due to stgit porcelain.


Cheers,
Mauro

      reply	other threads:[~2008-04-25  2:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-24 20:22 no help text for DVB_TUNER_ITD1000 Adrian Bunk
2008-04-24 20:28 ` Mauro Carvalho Chehab
2008-04-24 21:08   ` [v4l-dvb-maintainer] " Brandon Philips
2008-04-24 21:34     ` Mauro Carvalho Chehab
2008-04-24 23:39     ` Mauro Carvalho Chehab
2008-04-25  0:23       ` Brandon Philips
2008-04-25  2:16         ` Mauro Carvalho Chehab [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080424231640.3f8f2d9a@gaivota \
    --to=mchehab@infradead.org \
    --cc=bphilips@suse.de \
    --cc=bunk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pb@linuxtv.org \
    --cc=v4l-dvb-maintainer@linuxtv.org \
    --cc=zzam@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox