Fwd: [SPARC64] INO problem Re: [Bug 10273] New: Sun GEM (PCI) - network device doesn't work

Fwd: [SPARC64] INO problem Re: [Bug 10273] New: Sun GEM (PCI) - network device doesn't work

[Jarek Poplawski]

Nice work Jos! I forward it to the author and the lists.

Jarek P.

Andrew Morton wrote, On 03/17/2008 10:36 PM:

> On Mon, 17 Mar 2008 14:25:50 -0700 (PDT)
> bugme-daemon@bugzilla.kernel.org wrote:
> 
>> http://bugzilla.kernel.org/show_bug.cgi?id=10273
>>
>>            Summary: Sun GEM (PCI) - network device doesn't work

----- Forwarded message from bugme-daemon@bugzilla.kernel.org -----

> ------- Comment #24 from seraph@xs4all.nl  2008-04-02 07:24 -------
> I did bisection. The bad commit is:
> 
> 5a606b72a4309a656cd1a19ad137dc5557c4b8ea is first bad commit
> commit 5a606b72a4309a656cd1a19ad137dc5557c4b8ea
> Author: David S. Miller <davem@sunset.davemloft.net>
> Date:   Mon Jul 9 22:40:36 2007 -0700
> 
>     [SPARC64]: Do not ACK an INO if it is disabled or inprogress.
> 
> 
> -- 
> Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are on the CC list for the bug, or are watching someone who is.

----- End forwarded message -----

Re: [SPARC64] INO problem Re: [Bug 10273] New: Sun GEM (PCI) - network device doesn't work

[David Miller]

From: Jarek Poplawski <jarkao2@gmail.com>
Date: Wed, 2 Apr 2008 20:26:55 +0200

> Nice work Jos! I forward it to the author and the lists.

Thanks for tracking this down.

I'm very busy currently but I promise I'll try to resolve this
somehow.

Re: [SPARC64] INO problem Re: [Bug 10273] New: Sun GEM (PCI) - network device doesn't work

[David Miller]

From: Jarek Poplawski <jarkao2@gmail.com>
Date: Wed, 2 Apr 2008 20:26:55 +0200

> Nice work Jos! I forward it to the author and the lists.

I haven't forgotten about this bug report, in fact I did some
investigation and thinking about it.

I think the case being triggered in the new code is IRQ_DISABLED.

If this is the problem, I suspect that what needs to happen is that
when we re-enable the interrupt we have to forcefully hit the clear
register to put it back into transmit state.  Otherwise it can
get stuck.

Please give this patch a try (this is against 2.6.23, which is the
version you reported the bug against, let me know if another version
is more convenient).

Thanks!

diff --git a/arch/sparc64/kernel/irq.c b/arch/sparc64/kernel/irq.c
index 2395609..98b68d2 100644
--- a/arch/sparc64/kernel/irq.c
+++ b/arch/sparc64/kernel/irq.c
@@ -313,6 +313,8 @@ static void sun4u_irq_enable(unsigned int virt_irq)
 			 IMAP_AID_SAFARI | IMAP_NID_SAFARI);
 		val |= tid | IMAP_VALID;
 		upa_writeq(val, imap);
+
+		upa_writeq(ICLR_IDLE, data->iclr);
 	}
 }
 

Re: [SPARC64] INO problem Re: [Bug 10273] New: Sun GEM (PCI) - network device doesn't work

[Jos van der Ende]

> Please give this patch a try (this is against 2.6.23, which is the
> version you reported the bug against, let me know if another version
> is more convenient).

I applied the patch against 2.6.24-gentoo-r4, the current kernel on this machine. It worked fine, with only an offset of 12 lines. Nothing unusual during compile either.

The first results are hopeful: I am no longer able to trigger this bug by loading sym53c8xx before sungem, nor by having them both loaded by udev. Nothing odd in dmesg and the machine is completely functional.


I don't have much time for testing today, but if desired I will gladly do some more testing tomorrow or Sunday.


-- 
Jos van der Ende <seraph@xs4all.nl>

Re: [SPARC64] INO problem Re: [Bug 10273] New: Sun GEM (PCI) - network device doesn't work

[David Miller]

From: Jos van der Ende <seraph@xs4all.nl>
Date: Fri, 25 Apr 2008 21:59:05 +0200

> > Please give this patch a try (this is against 2.6.23, which is the
> > version you reported the bug against, let me know if another version
> > is more convenient).
> 
> I applied the patch against 2.6.24-gentoo-r4, the current kernel on this machine. It worked fine, with only an offset of 12 lines. Nothing unusual during compile either.
> 
> The first results are hopeful: I am no longer able to trigger this bug by loading sym53c8xx before sungem, nor by having them both loaded by udev. Nothing odd in dmesg and the machine is completely functional.
> 
> 
> I don't have much time for testing today, but if desired I will gladly do some more testing tomorrow or Sunday.

Thanks for testing the change, I'll do some of my own testing and push
the bug fix upstream.

Thanks again!