From: Matthew Wilcox <matthew@wil.cx>
To: Dean Nelson <dcn@sgi.com>
Cc: jes@sgi.com, tony.luck@intel.com, linux-ia64@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] allocate multiple contiguous pages via uncached allocator -v2
Date: Fri, 25 Apr 2008 12:50:00 -0600 [thread overview]
Message-ID: <20080425185000.GK14990@parisc-linux.org> (raw)
In-Reply-To: <20080425184606.GA13773@sgi.com>
On Fri, Apr 25, 2008 at 01:46:06PM -0500, Dean Nelson wrote:
> +++ linux-2.6/include/asm-ia64/uncached.h 2008-04-25 13:25:06.821572061 -0500
> @@ -8,5 +8,5 @@
> * Prototypes for the uncached page allocator
> */
>
> -extern unsigned long uncached_alloc_page(int nid);
> -extern void uncached_free_page(unsigned long);
> +extern unsigned long uncached_alloc_page(int, int);
> +extern void uncached_free_page(unsigned long, int);
It would be good to name the arguments, particularly since you can't
identify them by type.
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
prev parent reply other threads:[~2008-04-25 19:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-25 18:46 [PATCH] allocate multiple contiguous pages via uncached allocator -v2 Dean Nelson
2008-04-25 18:50 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080425185000.GK14990@parisc-linux.org \
--to=matthew@wil.cx \
--cc=dcn@sgi.com \
--cc=jes@sgi.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox