From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764443AbYDZA6O (ORCPT ); Fri, 25 Apr 2008 20:58:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1765065AbYDZA5u (ORCPT ); Fri, 25 Apr 2008 20:57:50 -0400 Received: from fmailhost03.isp.att.net ([207.115.11.53]:38693 "EHLO fmailhost01.isp.att.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759535AbYDZA5s (ORCPT ); Fri, 25 Apr 2008 20:57:48 -0400 X-Originating-IP: [65.12.36.143] Date: Fri, 25 Apr 2008 19:57:43 -0500 From: Jay Cliburn To: Alexey Dobriyan Cc: Jay Cliburn , Luca Tettamanti , Chris Snook , Jeff Garzik , Pekka Enberg , Andrew Morton , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Christoph Lameter , torvalds@osdl.org Subject: Re: atl1 64-bit => 32-bit DMA borkage (reproducible, bisected) Message-ID: <20080425195743.2bfe66ee@osprey.hogchain.net> In-Reply-To: <20080421210821.28053a92@osprey.hogchain.net> References: <20080414183221.GA5234@martell.zuzino.mipt.ru> <20080414195613.GA4772@martell.zuzino.mipt.ru> <20080419111719.GA6724@martell.zuzino.mipt.ru> <20080419144535.GA4814@martell.zuzino.mipt.ru> <20080419215444.2d4623f5@osprey.hogchain.net> <20080420111453.GA4902@martell.zuzino.mipt.ru> <20080420060607.2b1be48b@osprey.hogchain.net> <20080420122631.GA4761@martell.zuzino.mipt.ru> <20080420133704.63f5cc10@osprey.hogchain.net> <20080420205500.GA4762@martell.zuzino.mipt.ru> <20080421210821.28053a92@osprey.hogchain.net> X-Mailer: Claws Mail 3.3.1 (GTK+ 2.12.5; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 21 Apr 2008 21:08:21 -0500 Jay Cliburn wrote: > > Alexey, can you please try this (very minimally tested) patch? Alexey, have you found time to try this patch yet? Thanks. > > diff --git a/drivers/net/atlx/atl1.c b/drivers/net/atlx/atl1.c > index 5586fc6..07fe5c0 100644 > --- a/drivers/net/atlx/atl1.c > +++ b/drivers/net/atlx/atl1.c > @@ -1115,9 +1115,6 @@ static void atl1_free_ring_resources(struct > atl1_adapter *adapter) struct atl1_rrd_ring *rrd_ring = > &adapter->rrd_ring; struct atl1_ring_header *ring_header = > &adapter->ring_header; > - atl1_clean_tx_ring(adapter); > - atl1_clean_rx_ring(adapter); > - > kfree(tpd_ring->buffer_info); > pci_free_consistent(pdev, ring_header->size, > ring_header->desc, ring_header->dma); > @@ -3423,6 +3420,8 @@ static int atl1_set_ringparam(struct net_device > *netdev, adapter->rrd_ring = rrd_old; > adapter->tpd_ring = tpd_old; > adapter->ring_header = rhdr_old; > + atl1_clean_tx_ring(adapter); > + atl1_clean_rx_ring(adapter); > atl1_free_ring_resources(adapter); > adapter->rfd_ring = rfd_new; > adapter->rrd_ring = rrd_new;