Re: latest git (linux-2.6.25-git6) compile error

[Ivo van Doorn <ivdoorn@gmail.com>]

On Friday 25 April 2008, David Miller wrote:
> From: Plamen Petrov <plamen.petrov@fs.ru.acad.bg>
> Date: Fri, 25 Apr 2008 09:02:15 +0300
> 
> > Ivo van Doorn wrote:
> > > Can you confirm that this error goes away when enabling CONFIG_NEW_LEDS ?
> > >
> > > Ivo
> > >   
> > Will try and report later - now I'm at work, away from the machine.
> 
> This should have been fixed by the patch below.
> 
> Or is it the problem that simply selecting LEDS_CLASS doesn't take
> care of LEDS_CLASS's dependencies such as NEW_LEDS?  Ugh, if so...

The config file from Plamen contains:
# CONFIG_NEW_LEDS is not set
CONFIG_LEDS_CLASS=y

So this is a dependency problem, I guess the functions:
led_classdev_resume
led_classdev_suspend
led_classdev_register
led_classdev_unregister
are only compiled in when NED_LEDS is selected. :S

Ivo

> commit 201410ce85d80b7b893cdc72e944a1341dd393f1
> Author: David S. Miller <davem@davemloft.net>
> Date:   Wed Apr 23 03:34:50 2008 -0700
> 
>     rt2x00: Select LEDS_CLASS.
>     
>     Signed-off-by: David S. Miller <davem@davemloft.net>
> 
> diff --git a/drivers/net/wireless/rt2x00/Kconfig b/drivers/net/wireless/rt2x00/Kconfig
> index a1e3938..ab1029e 100644
> --- a/drivers/net/wireless/rt2x00/Kconfig
> +++ b/drivers/net/wireless/rt2x00/Kconfig
> @@ -60,7 +60,8 @@ config RT2400PCI_RFKILL
>  
>  config RT2400PCI_LEDS
>  	bool "RT2400 leds support"
> -	depends on RT2400PCI && LEDS_CLASS
> +	depends on RT2400PCI
> +	select LEDS_CLASS
>  	select RT2X00_LIB_LEDS
>  	---help---
>  	  This adds support for led triggers provided my mac80211.
> @@ -86,7 +87,8 @@ config RT2500PCI_RFKILL
>  
>  config RT2500PCI_LEDS
>  	bool "RT2500 leds support"
> -	depends on RT2500PCI && LEDS_CLASS
> +	depends on RT2500PCI
> +	select LEDS_CLASS
>  	select RT2X00_LIB_LEDS
>  	---help---
>  	  This adds support for led triggers provided my mac80211.
> @@ -114,7 +116,8 @@ config RT61PCI_RFKILL
>  
>  config RT61PCI_LEDS
>  	bool "RT61 leds support"
> -	depends on RT61PCI && LEDS_CLASS
> +	depends on RT61PCI
> +	select LEDS_CLASS
>  	select RT2X00_LIB_LEDS
>  	---help---
>  	  This adds support for led triggers provided my mac80211.
> @@ -130,7 +133,8 @@ config RT2500USB
>  
>  config RT2500USB_LEDS
>  	bool "RT2500 leds support"
> -	depends on RT2500USB && LEDS_CLASS
> +	depends on RT2500USB
> +	select LEDS_CLASS
>  	select RT2X00_LIB_LEDS
>  	---help---
>  	  This adds support for led triggers provided my mac80211.
> @@ -148,7 +152,8 @@ config RT73USB
>  
>  config RT73USB_LEDS
>  	bool "RT73 leds support"
> -	depends on RT73USB && LEDS_CLASS
> +	depends on RT73USB
> +	select LEDS_CLASS
>  	select RT2X00_LIB_LEDS
>  	---help---
>  	  This adds support for led triggers provided my mac80211.
>