From: Andrew Morton <akpm@linux-foundation.org>
To: Jean Delvare <khali@linux-fr.org>
Cc: alek.du@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] i2c: Add Intel SCH I2C SMBus support
Date: Fri, 25 Apr 2008 23:10:01 -0700 [thread overview]
Message-ID: <20080425231001.97cabebc.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080423143212.36dba2ea@hyperion.delvare>
> On Wed, 23 Apr 2008 14:32:12 +0200 Jean Delvare <khali@linux-fr.org> wrote:
> Hi Alek,
>
> On Tue, 22 Apr 2008 10:04:20 +0800, alek du wrote:
> > This patch adds Intel SCH chipsets (US15W, US15L, UL11L) i2c bus support.
>
> What kind of machines are these?
>
> >
> > Signed-off-by: Alek Du <alek.du@intel.com>
> > ---
> > drivers/i2c/busses/Kconfig | 7 +
> > drivers/i2c/busses/Makefile | 1 +
> > drivers/i2c/busses/i2c-sch.c | 419 ++++++++++++++++++++++++++++++++++++++++++
> > 3 files changed, 427 insertions(+), 0 deletions(-)
> > create mode 100644 drivers/i2c/busses/i2c-sch.c
> > (...)
>
> MAINTAINERS says:
>
> I2C SUBSYSTEM
> (...)
> L: i2c@lm-sensors.org
>
> So it would be great if you could send your patch there rather than on
> LKML.
>
"as well as" would be better than "rather than", please.
I worry about the inclusion of apm_bios.h. The driver is configured to be
available on all architectures but apm_bios.h is surely x86-specific (and
maybe mips).
But afaict the inclusion is not needed?
next prev parent reply other threads:[~2008-04-26 6:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-22 2:04 [PATCH 2/3] i2c: Add Intel SCH I2C SMBus support alek du
2008-04-23 12:32 ` Jean Delvare
2008-04-24 1:33 ` Alek Du
2008-04-26 6:10 ` Andrew Morton [this message]
2008-04-26 9:17 ` Jean Delvare
-- strict thread matches above, loose matches on Subject: below --
2008-04-22 2:16 alek du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080425231001.97cabebc.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alek.du@intel.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox