From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755128AbYDZLKE (ORCPT ); Sat, 26 Apr 2008 07:10:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752291AbYDZLJx (ORCPT ); Sat, 26 Apr 2008 07:09:53 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:38778 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752149AbYDZLJx (ORCPT ); Sat, 26 Apr 2008 07:09:53 -0400 Date: Sat, 26 Apr 2008 13:09:02 +0200 From: Ingo Molnar To: Mathieu Desnoyers Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Jason Baron , Rusty Russell , Adrian Bunk , Andi Kleen , Christoph Hellwig , akpm@osdl.org Subject: Re: [patch 13/37] Immediate Values - Architecture Independent Code Message-ID: <20080426110901.GA31497@elte.hu> References: <20080424150324.802695381@polymtl.ca> <20080424151357.576697846@polymtl.ca> <20080425145552.GA20351@elte.hu> <20080426093641.GA10060@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080426093641.GA10060@elte.hu> User-Agent: Mutt/1.5.17 (2007-11-01) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Ingo Molnar wrote: > > randconfig testing in sched-devel caught a build bug - fixed by the > > patch below. > > found another build failure - the better fix is the one below. or rather the one below ... ------------> Subject: markers: fix2 From: Ingo Molnar Date: Sat Apr 26 11:19:00 CEST 2008 Signed-off-by: Ingo Molnar --- include/linux/module.h | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) Index: linux/include/linux/module.h =================================================================== --- linux.orig/include/linux/module.h +++ linux/include/linux/module.h @@ -472,9 +472,6 @@ extern void print_modules(void); extern void module_update_markers(void); -extern void _module_imv_update(void); -extern void module_imv_update(void); - #else /* !CONFIG_MODULES... */ #define EXPORT_SYMBOL(sym) #define EXPORT_SYMBOL_GPL(sym) @@ -579,15 +576,19 @@ static inline void module_update_markers { } +#endif /* CONFIG_MODULES */ + +#if defined(CONFIG_MODULES) && defined(CONFIG_IMMEDIATE) +extern void _module_imv_update(void); +extern void module_imv_update(void); +#else static inline void _module_imv_update(void) { } - static inline void module_imv_update(void) { } - -#endif /* CONFIG_MODULES */ +#endif struct device_driver; #ifdef CONFIG_SYSFS