[patch] latest git: DEV_BLK_4DRIVES should be a tristate

[patch] latest git: DEV_BLK_4DRIVES should be a tristate

[Frederik Deweerdt]

Hello Bartlomiej,

The 4drives should be a tristate, the following breakage occurs
otherwise:
ERROR: "probe_4drives" [drivers/ide/ide-core.ko] undefined!

The following (compile tested) patch fixes it for me.

Regards,
Frederik


Signed-off-by: Frederik Deweerdt <frederik.deweerdt@gmail.com>

diff --git a/drivers/ide/Kconfig b/drivers/ide/Kconfig
index 8753203..3f9e100 100644
--- a/drivers/ide/Kconfig
+++ b/drivers/ide/Kconfig
@@ -1031,7 +1031,7 @@ comment "Other IDE chipsets support"
 comment "Note: most of these also require special kernel boot parameters"
 
 config BLK_DEV_4DRIVES
-	bool "Generic 4 drives/port support"
+	tristate "Generic 4 drives/port support"
 	help
 	  Certain older chipsets, including the Tekram 690CD, use a single set
 	  of I/O ports at 0x1f0 to control up to four drives, instead of the

Re: [patch] latest git: DEV_BLK_4DRIVES should be a tristate

[Adrian Bunk]

On Thu, Apr 24, 2008 at 05:07:17PM +0200, Frederik Deweerdt wrote:
> Hello Bartlomiej,
> 
> The 4drives should be a tristate, the following breakage occurs
> otherwise:
> ERROR: "probe_4drives" [drivers/ide/ide-core.ko] undefined!
>...

"ide: remove obsoleted "idex=" kernel parameters" will already fix this 
breakage.

Bart, can you push this patch?

> Regards,
> Frederik
>...

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [patch] latest git: DEV_BLK_4DRIVES should be a tristate

[Bartlomiej Zolnierkiewicz]

On Thursday 24 April 2008, Adrian Bunk wrote:
> On Thu, Apr 24, 2008 at 05:07:17PM +0200, Frederik Deweerdt wrote:
> > Hello Bartlomiej,
> > 
> > The 4drives should be a tristate, the following breakage occurs
> > otherwise:
> > ERROR: "probe_4drives" [drivers/ide/ide-core.ko] undefined!
> >...
> 
> "ide: remove obsoleted "idex=" kernel parameters" will already fix this 
> breakage.
> 
> Bart, can you push this patch?

I applied Frederik's fix ("ide: remove obsoleted "idex=" kernel parameters"
depends on some other patches that need to pushed first).

Thanks,
Bart