From: Denys Vlasenko <vda.linux@googlemail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: David Chinner <dgc@sgi.com>,
xfs@oss.sgi.com, Eric Sandeen <sandeen@sandeen.net>,
Adrian Bunk <bunk@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc()
Date: Sun, 27 Apr 2008 01:45:11 +0200 [thread overview]
Message-ID: <200804270145.11632.vda.linux@googlemail.com> (raw)
In-Reply-To: <20080426200347.GA21021@infradead.org>
On Saturday 26 April 2008 22:03, Christoph Hellwig wrote:
> On Sat, Apr 26, 2008 at 04:51:02PM +0200, Denys Vlasenko wrote:
> > Hi David,
> >
> > This patch reduces xfs_bmap_btalloc() stack usage by 50 bytes
> > by moving part of its body into a helper function.
> >
> > This results in some variables not taking stack space in
> > xfs_bmap_btalloc() anymore.
>
> I think this is a good idea, although I'd rather split the function at
> a local boundary. The patch below (which passes xfsqa) does that
> by splitting out the handling of the most complicated nullfb case
> out. It probably won't help reducing stack useage as much as yours,
> but it helps beeing able to read the code a little better.
It saves only 16 bytes of stack.
--
vda
next prev parent reply other threads:[~2008-04-26 23:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-26 14:51 [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc() Denys Vlasenko
2008-04-26 18:54 ` Eric Sandeen
2008-04-26 23:05 ` Denys Vlasenko
2008-04-26 20:03 ` Christoph Hellwig
2008-04-26 23:45 ` Denys Vlasenko [this message]
2008-04-27 23:40 ` David Chinner
2008-04-27 23:57 ` Denys Vlasenko
2008-04-28 3:32 ` David Chinner
[not found] <200804261651.02078.vda.linux__2040.04651536724$1209223026$gmane$org@googlemail.com>
2008-04-26 20:02 ` Andi Kleen
2008-04-26 20:07 ` Christoph Hellwig
2008-04-26 20:26 ` Andi Kleen
2008-04-26 20:23 ` Christoph Hellwig
2008-04-28 0:06 ` Nathan Scott
2008-04-28 5:56 ` Christoph Hellwig
2008-04-28 10:32 ` Andi Kleen
2008-04-28 23:52 ` Nathan Scott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804270145.11632.vda.linux@googlemail.com \
--to=vda.linux@googlemail.com \
--cc=bunk@kernel.org \
--cc=dgc@sgi.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox