From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758302AbYD0Kfu (ORCPT ); Sun, 27 Apr 2008 06:35:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752672AbYD0Kfm (ORCPT ); Sun, 27 Apr 2008 06:35:42 -0400 Received: from brick.kernel.dk ([87.55.233.238]:27918 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752647AbYD0Kfl (ORCPT ); Sun, 27 Apr 2008 06:35:41 -0400 Date: Sun, 27 Apr 2008 12:35:34 +0200 From: Jens Axboe To: Geert Uytterhoeven Cc: Andrew Morton , Christoph Hellwig , Linux Kernel Development , Cell Broadband Engine OSS Development Subject: Re: [PATCH] ps3disk: Remove superfluous cast Message-ID: <20080427103534.GU12774@kernel.dk> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 23 2008, Geert Uytterhoeven wrote: > As ps3disk is a ppc64-only driver, sector_t equals to unsigned long, and the > cast is not needed. > > Reuse in another (possibly 32-bit) driver is protected by the safety net called > `compiler warning' (with the cast, it may silently truncate to 32-bit). > If sector_t ever changes, we will get a compiler warning as well (with the > cast, we won't). > > Signed-off-by: Geert Uytterhoeven > Acked-by: Christoph Hellwig > --- > Please apply, thx! Applied -- Jens Axboe