From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761980AbYD0R6O (ORCPT ); Sun, 27 Apr 2008 13:58:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756585AbYD0R6F (ORCPT ); Sun, 27 Apr 2008 13:58:05 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:43528 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755743AbYD0R6E (ORCPT ); Sun, 27 Apr 2008 13:58:04 -0400 Date: Sun, 27 Apr 2008 13:57:54 -0400 From: Christoph Hellwig To: Linus Torvalds Cc: Adrian Bunk , Sam Ravnborg , linux arch , LKML , Ingo Molnar , David Miller Subject: Re: [PATCH] prepare kconfig inline optimization for all architectures Message-ID: <20080427175754.GA28483@infradead.org> References: <20080427105100.GA14795@uranus.ravnborg.org> <20080427113158.GY2252@cs181133002.pp.htv.fi> <20080427172235.GA2252@cs181133002.pp.htv.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 27, 2008 at 10:32:28AM -0700, Linus Torvalds wrote: > Modern versions of gcc may do the right thing. Note the two very important > code-words: "modern" and "may". It's even worse than that, that may not even get it right. That's why we need always_inline to force it when we know we need it. Now for the cases where we don't know know that we either need or really really strongly want it we should just not mark it inline at all.